From: Thomas Monjalon <thomas@monjalon.net>
To: Sarosh Arif <sarosh.arif@emumba.com>
Cc: sthemmin@microsoft.com, dev@dpdk.org, stephen@networkplumber.org
Subject: Re: [dpdk-dev] [v3 PATCH] usertools: show an error message if unable to reserve requested hugepages
Date: Fri, 05 Feb 2021 19:24:10 +0100 [thread overview]
Message-ID: <1752015.tdlpT8OkTY@thomas> (raw)
In-Reply-To: <20210108090627.17365-1-sarosh.arif@emumba.com>
08/01/2021 10:06, Sarosh Arif:
> Sometimes the system is unable to reserve the requested hugepages because
> enough space is not available in the RAM. In that case, currently the
> script displays no error message hence the user can be under the delusion
> that the hugepages requested are all successfully reserved. This patch
> displays an error message if the pages reserved are different from the
> requested pages.
>
> Signed-off-by: Sarosh Arif <sarosh.arif@emumba.com>
> ---
> v2:
> use a global variable SHOW_HUGEPAGES to remove linter warnings
> v3:
> only print an error message if unable to reserve hugepages.
> ---
> + if get_hugepages(path) != pages:
> + sys.exit("Unable to reserve required pages.")
Replaced double quotes by simple ones.
Applied, thanks.
prev parent reply other threads:[~2021-02-05 18:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-30 12:45 [dpdk-dev] [PATCH] " Sarosh Arif
2020-11-30 16:43 ` Stephen Hemminger
2020-12-17 11:16 ` [dpdk-dev] [v2 PATCH] " Sarosh Arif
2020-12-17 18:15 ` Stephen Hemminger
2021-01-07 8:06 ` Sarosh Arif
2021-01-07 15:37 ` Stephen Hemminger
2021-01-08 9:06 ` [dpdk-dev] [v3 " Sarosh Arif
2021-02-05 18:24 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1752015.tdlpT8OkTY@thomas \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=sarosh.arif@emumba.com \
--cc=stephen@networkplumber.org \
--cc=sthemmin@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).