From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BC1E941EB2; Thu, 16 Mar 2023 18:07:24 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AD13340DF6; Thu, 16 Mar 2023 18:07:24 +0100 (CET) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by mails.dpdk.org (Postfix) with ESMTP id DF36040DDC for ; Thu, 16 Mar 2023 18:07:23 +0100 (CET) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 91C5E5C0150; Thu, 16 Mar 2023 13:07:23 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Thu, 16 Mar 2023 13:07:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1678986443; x=1679072843; bh=R1unvu/nwEVaG3ga/Amkgmr3zpT5zJD8jbz Ri9K190I=; b=I+HKIeG/igabhTydofrr+QSQABESQ2Biq9QlCykoFzLI8Hq1LjQ 21xkznJAOfaKbtehGQdbYQRYroKEU7lMfnhklVjLDcYcesOsomivmnkQLh83oPdP kZ6hsVXoyd1FZm9x5BinOG+eVK0BlMEOT3ncpdBLC9R+EJCTaEpSh+l6TIZLPApJ VGosBXIKbgplja3jiSlumMp98Rpfd5PiGb8ASNeFxRrycApX3P0Ub6kg07Aw9rjL SiYaPtiZBjH5RbUzpKy8uJH60bspCHGfHZ4Wni/g3EFxTCUIsmUD/WIySFxkXGku kVX5HKd//Ds4KH8H9w0bXhAzfKKciko0wFg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1678986443; x=1679072843; bh=R1unvu/nwEVaG3ga/Amkgmr3zpT5zJD8jbz Ri9K190I=; b=DykYbVN8SZKkdNSgKYWmcws3MbqCf0brOqIy1b+KsSl4fQnJk0j 7u18s6xf48l9vq7TmOZTov7u5Pasq3Pmz4850+7Wp6hD3Ydi0t6Pvi/8T8swA/VP 4kezKlG6EdjcFi9Z7e8on2PF3tgX0nonjQgBZ46EEEd/GWCtfstCRXg2OK4EgI9L MEdjWeYCHIfjczSUoPEQ94XC+PHQOrIRkwI29k7VgZkp98GKh86Ok2ypl+ZdTOko ssPypmlnAED0dGkm94PdW/i61idRzjJvHnsXwR7X/FKbFgwnZOjSr5/4YlUh7G7/ PwQ2YZywTXN07rqQfKm1SefTrgDm1gm6vPg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdeftddgleejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 16 Mar 2023 13:07:22 -0400 (EDT) From: Thomas Monjalon To: Srikanth Yalavarthi Cc: Prince Takkar , Shivah Shankar Shankar Narayan Rao , "dev@dpdk.org" , Anup Prabhu , Srikanth Yalavarthi Subject: Re: [EXT] Re: [PATCH v2 1/1] ml/cnxk: fix multiple coverity issues Date: Thu, 16 Mar 2023 18:07:21 +0100 Message-ID: <1752339.VLH7GnMWUR@thomas> In-Reply-To: References: <20230315135427.11489-1-syalavarthi@marvell.com> <21806585.EfDdHjke4D@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 16/03/2023 18:02, Srikanth Yalavarthi: > > -----Original Message----- > > From: Thomas Monjalon > > Sent: 16 March 2023 22:30 > > To: Srikanth Yalavarthi > > Cc: Prince Takkar ; Shivah Shankar Shankar Narayan > > Rao ; dev@dpdk.org; Anup Prabhu > > > > Subject: [EXT] Re: [PATCH v2 1/1] ml/cnxk: fix multiple coverity issues > > > > External Email > > > > ---------------------------------------------------------------------- > > 16/03/2023 10:33, Srikanth Yalavarthi: > > > Added checks for null pointers. Removed logically dead code. > > > Fix division or modulo by zero. Fix evaluation order violation issues. > > > Fix potential memory leak in xstats function. > > > > I think it would be better to split this patch a little, so we can easily see what > > are the reasons for the changes. > > Separate patch for each Coverity issue? Maybe yes. Or try to group similar causes.