From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 529149605 for ; Mon, 21 May 2018 10:39:44 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id C4F6D21DB4; Mon, 21 May 2018 04:39:43 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 21 May 2018 04:39:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=GhsIumnyaefIDq6RrSSsEYH2AE nN0bgopF0pNRpk2k0=; b=g+2BcaabPmO193cLLjYbrOvbtUXqbdKUTaG6O4cGx1 TPEbWfxjRu0XIciigTQXVIj8TjCp5CPudRMzR9Edl4rrtoQk93A9LXO9WPn8jL+M ru2Evkr0eeI78G1Wf+gT3pVbLrSl8zEWUSRVRk3tfZ0cd3tiigCzoRDH33icZL6W Y= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=GhsIum nyaefIDq6RrSSsEYH2AEnN0bgopF0pNRpk2k0=; b=WYbbqCmqMo3MCcgc0j6yaN hklzI1k4HqzursOcfQoyv93p3ndkTzx9fA5uUHFDX+0pDNelj4xmHONLvCT3IKpP y/QyAehPqfBBmpR3WaKFZsX/Xe/wsuYQnPz411o2empM4CVReUVmv/XgtlRLjhbA kdGQmbM7IfOCrN5/59U0ljLYwHd/QsBvV5g50/toJaDJ93InqckNv2XgypnS/uoE gC2L47OASyw9LY8XIGyvmEm5LnAD04WmKsbRP2TndZ72k2OV+c8/cjBgPyxClTW5 d2VUesMAqL3oec1O7oBCv/xo8R1EvquguN5MWKcvsVgzhCLB779Rl+KgWy/kcjRw == X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Sender: Received: from xps.localnet (114.149.6.93.rev.sfr.net [93.6.149.114]) by mail.messagingengine.com (Postfix) with ESMTPA id DE10AE4911; Mon, 21 May 2018 04:39:42 -0400 (EDT) From: Thomas Monjalon To: Zijie Pan Cc: Laurent Hardy , dev , "beilei.xing" , "qi.z.zhang" , "helin.zhang" Date: Mon, 21 May 2018 10:39:41 +0200 Message-ID: <1752366.FEJfUWy9xN@xps> In-Reply-To: References: <1526638447-31246-1-git-send-email-zijie.pan@6wind.com> <3140133.83vjVej6t9@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] net/i40e: add a specific API to control the LLDP agent X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 May 2018 08:39:44 -0000 21/05/2018 05:35, Zijie Pan: > > > Add a new API rte_pmd_i40e_set_lldp_cmd to control LLDP agent for i40e. > > > It supports the following i40e debug lldp commands: > > > - start/stop of the LLDP agent. > > > - get local/remote of the LLDP MIB (Management Information Base). > > > > > > Signed-off-by: Laurent Hardy > > > Signed-off-by: Zijie Pan > > > > Does it mean that this feature is enabled by default in i40e devices? > > Should it be disabled by default? > > The new API is just an interface to control the LLDP agent. No functions of i40e call it by default. It is only used to debug LLDP of i40e devices. For example we can add a new command for test-pmd to debug lldp of i40e by calling rte_pmd_i40e_set_lldp_cmd(). There is a command to stop the LLDP agent. My question is to know whether this agent is running by default and should be disabled? I mean i40e is generating LLDP packets by default?