From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E2515A0093; Mon, 15 Jun 2020 17:21:35 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CED2F2B94; Mon, 15 Jun 2020 17:21:34 +0200 (CEST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id E0ABAFFA for ; Mon, 15 Jun 2020 17:21:33 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 758F05C00B3; Mon, 15 Jun 2020 11:21:30 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Mon, 15 Jun 2020 11:21:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= eennOBEjDgeEGiqHz6weGSJb3gEFbzoddNgh4xqJU/c=; b=libodTsENxkd9i3q oSEia3KFWOPMwu9Ph6/BBWum6V/9906Btauh/RjGleaHoPruqJR+4QDxcv+296Z4 gIzXWtBjxqpK4BF59u2dAkazECxU0eRkBIVI5n76VelaGHhiMGxjuVDxbnT8XCLn ZHMjfwcXhMALz3qTyH9vLZOE5bQiIacOo2WcOtknRNn177hOKCOl4YpDRthBxIcQ kYX2d0acpb9XSiQD70AYa2FLgZiaL4ZrRdgTuvxnfiggDiXfSNY7IEgHI7py9JJl QpDSwts66MBpzTsh0IxOpbiuyjh2l84+mmrcVm2cTFwvqu6lIDnz+dcKA4eledHc v/iwqA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=eennOBEjDgeEGiqHz6weGSJb3gEFbzoddNgh4xqJU /c=; b=ncnxFbMSV90b76eV3VgVwrlbr9pHszKBqBh0SWPuzwUngVpRVuqRkulVd nOlF6bpltiGS6lZsV+g1KBptA9bHl3RxMlMr85iWM5cH+3SzD0JpskVS6GDvteeF rljbU0S2kce4JCTq20tYS5SptRF1qD4Q+uVK9I/03VEC4ej54pV53nB9LlwXRDDs niJ0Xjh5TIR3Pl8S5hWkNd2iGWp75MyJVyOYohxkJ2FeTffYVg92CV37bJYbLIWg 3DlE2qs698Of6XeDIq5qVlGhy88cLz4dM/eXvL/dpwHUbQabdFfffuTu2McQeqnd gmiEQ1jDN3YcG5bLjh4nUNxEAaAvQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrudeikedgkeeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id B0A08328006A; Mon, 15 Jun 2020 11:21:28 -0400 (EDT) From: Thomas Monjalon To: Dmitry Kozlyuk Cc: dev@dpdk.org, Dmitry Malloy , Narcisa Ana Maria Vasile , Fady Bader , Tal Shnaiderman , Dmitry Kozlyuk , Harini Ramakrishnan , Omar Cardona , Pallavi Kadam , Ranjit Menon Date: Mon, 15 Jun 2020 17:21:27 +0200 Message-ID: <1754763.i1IbAELrZl@thomas> In-Reply-To: <20200615004354.14380-10-dmitry.kozliuk@gmail.com> References: <20200610142730.31376-1-dmitry.kozliuk@gmail.com> <20200615004354.14380-1-dmitry.kozliuk@gmail.com> <20200615004354.14380-10-dmitry.kozliuk@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v9 09/12] eal/windows: improve CPU and NUMA node detection X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 15/06/2020 02:43, Dmitry Kozlyuk: > + infos_size = 0; > + if (!GetLogicalProcessorInformationEx( > + RelationNumaNode, NULL, &infos_size)) { > + DWORD error = GetLastError(); > + if (error != ERROR_INSUFFICIENT_BUFFER) { > + log_early("Cannot get NUMA node info size, error %lu\n", > + GetLastError()); > + rte_errno = ENOMEM; > + return -1; > + } > + } > + > + infos = malloc(infos_size); > + if (infos == NULL) { > + log_early("Cannot allocate memory for NUMA node information\n"); > + rte_errno = ENOMEM; > + return -1; > + } > + > + if (!GetLogicalProcessorInformationEx( > + RelationNumaNode, infos, &infos_size)) { > + log_early("Cannot get NUMA node information, error %lu\n", > + GetLastError()); > + rte_errno = EINVAL; > + return -1; > + } rte_errno is unknown It seems to be fixed in patch 12: --- a/lib/librte_eal/windows/eal_windows.h +++ b/lib/librte_eal/windows/eal_windows.h @@ -9,8 +9,24 @@ * @file Facilities private to Windows EAL */ +#include #include I'll merge it in patch 9