From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id EF79D1B1AA for ; Mon, 18 Sep 2017 16:42:03 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id B8E67211E5; Mon, 18 Sep 2017 10:42:02 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Mon, 18 Sep 2017 10:42:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=a5vrL7PgxoxBJ2y MXl5I06YZ9r8WhrHD6hA6BvcHx0g=; b=mW9/br9bdMocNelXnLlviXkur3WwNvY qPawbxuJF58DPJDzjwk5ihDzzQDJ/TLHyGC1stS0VZbIqL/Byid1SNlxjQmcJ814 F6YV4qy3+zKJLJcLrFVbd8UiWg+JAU601TbP9t/Pa5xCo8AmppSZhntyKEEdKlRB BhFfvGoZ1A8w= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=a5vrL7PgxoxBJ2yMXl5I06YZ9r8WhrHD6hA6BvcHx0g=; b=RhTsHbLo RCm7E5CDUXe3jXFqCjGQWrs8HVoIQiW2fG2BEvmTfYugEIpOSQLrzOF4+1bSvqS3 eVHO1rKiblfgseWJ0vOyIzl10q2wLH6/jNaxyrYs7xxC3nu96oudKkVq6fZLTzgQ zo4fosBXugwDjDltHqgIMGWAhnoydRtm05lHoDdQV32imjLl+395HAU0//YM+Gf6 5woCRKX7gNj23+Mp/DIob4C6T8TDc1Hzzs4TThDgUeA3dZERQrBNEkQs64FAWoWE +TfmuWVOrFdO0T1sbmWrTJAOu9JmaFPqoL3S6/QK9pT8yCEXnyjs5mFlm38VsMy0 ajxa0OyHvkXKXw== X-ME-Sender: X-Sasl-enc: mu2yWScik6PvVBufJHTrpPA1/1dW7QN+6rrwCZcGioTd 1505745722 Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 5D834248ED; Mon, 18 Sep 2017 10:42:02 -0400 (EDT) From: Thomas Monjalon To: Shahaf Shuler Cc: Bruce Richardson , "Ananyev, Konstantin" , stephen@networkplumber.org, dev@dpdk.org Date: Mon, 18 Sep 2017 16:42:01 +0200 Message-ID: <1755631.UT9ibzIRJv@xps> In-Reply-To: References: <20170918113733.GA14460@bricha3-MOBL3.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 4/4] ethdev: add helpers to move to the new offloads API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Sep 2017 14:42:04 -0000 18/09/2017 16:27, Shahaf Shuler: > Monday, September 18, 2017 2:38 PM, Bruce Richardson > > On Mon, Sep 18, 2017 at 01:32:29PM +0200, Thomas Monjalon wrote: > > > 18/09/2017 13:11, Ananyev, Konstantin: > > > > From: Richardson, Bruce > > > > > > > > > > > > I think we all in favor to have a separate API here. > > > > > > Though from the discussion we had at latest TB, I am not sure it > > > > > > is doable in 17.11 timeframe. > > > > > > > > > > Ok, so does that imply no change in this release, and that the > > > > > existing set is to be ignored? > > > > > > > > No, my understanding the current plan is to go forward with Shahaf > > > > patches, and then apply another one (new set/get API) on top of them. > > > > > > Yes, it is what we agreed (hope to see it in minutes). > > > If someone can do these new patches in 17.11 timeframe, it's great! > > > Bruce, do you want to make it a try? > > > > If I have the chance, I can try, but given how short time is and that userspace > > is on next week, I very much doubt I'll even get it started. > > I wasn't aware to the techboard decision on the extra patchset needed. > I think it will be wrong to introduce an API on 17.11 and change it again on 18.02. > I will do my best to make everything ready for 17.11 so we can have one solid API on top of which all PMDs and application will be converted. Considering some Holidays and the DPDK summit I won't have much time to work on it. > > The plan is as follows: > 1. complete the last comment on the current series and integrate it. > 2. send a new patchset to convert to the API suggested above. Thank you Shahaf. > Aggregating the different suggestions I come up with the below. if this is agreed, then I will move with the implementation. > (I thought it is good to return error values for the get function). [...] > ** > * Set Tx offloads on a specific port. > * > * @param port_id > * The port identifier of the Ethernet device. > * @param offloads_mask > * Indicates which offloads to be set using DEV_TX_OFFLOAD_* flags. > * @return > * (0) if all offloads set successfully, otherwise offloads > * flags which were not set. > * > */ > uint64_t rte_eth_set_port_tx_offloads(uint8_t port_id, uint64_t offloads_mask); You need to have a parameter for the offloads value, different of offloads mask: set(port, value, mask) Or as proposed by Bruce, you need 2 functions: enable(port, mask) disable(port, mask)