From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wg0-f52.google.com (mail-wg0-f52.google.com [74.125.82.52])
 by dpdk.org (Postfix) with ESMTP id DFDE4C3D2
 for <dev@dpdk.org>; Mon, 11 May 2015 10:28:22 +0200 (CEST)
Received: by wgiu9 with SMTP id u9so120754051wgi.3
 for <dev@dpdk.org>; Mon, 11 May 2015 01:28:21 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=hjcz7CTAnAwHlPMIpXARO1eGjlpRusqsJ1Qckfo+T88=;
 b=KixQXGB60hK2r9zmuuc5F92yS7Q0EfePV1BW4OM4Pvq4l1hGvdMSGvTwAKN4g3DFnx
 H48iIq+xYmiB134oTf0gOHgXq7BS3AZ5OB0nW8/nXPWcoiHSVQjJCxkQKjVpUX3rc1V3
 sglPidMiXsyTjLWtj74Nri9nc32e10QH5eIq3KI3WIGDkzwT71Dbsg6pC2GmDfdqId7y
 2qYsVmZOP/UvTK8bdos2aIhxdpANuS83nMYMeZT3SYnq+gikzSp/d66GQ6dWXqKCh00C
 8DvHqyUQmqQpUeXchhAuFHYD5w78s1oPZ8vt9gneVRRtFgiqUQj6wtLNvAJ1ZR+dxMA0
 c5bw==
X-Gm-Message-State: ALoCoQnL28S96dvlRNz5z3hbH8+tD05uQIHjsXsx8WsLgyxYmajZUVz47X4A9FKk4XxSKT06WTXY
X-Received: by 10.180.107.38 with SMTP id gz6mr17204183wib.63.1431332901790;
 Mon, 11 May 2015 01:28:21 -0700 (PDT)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by mx.google.com with ESMTPSA id ex2sm21604381wjd.28.2015.05.11.01.28.20
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Mon, 11 May 2015 01:28:20 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
Date: Mon, 11 May 2015 10:27:40 +0200
Message-ID: <1757105.2rpKOWrz79@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.7 (Linux/4.0.1-1-ARCH; KDE/4.14.7; x86_64; ; )
In-Reply-To: <E115CCD9D858EF4F90C690B0DCB4D897272A5290@IRSMSX108.ger.corp.intel.com>
References: <1430829319-22242-1-git-send-email-pablo.de.lara.guarch@intel.com>
 <8281433.nBqoHGD3WT@xps13>
 <E115CCD9D858EF4F90C690B0DCB4D897272A5290@IRSMSX108.ger.corp.intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="utf-8"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v3] kni: fix compilation issue in KNI vhost
	on kernel 3.19/4.0
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 11 May 2015 08:28:23 -0000

2015-05-10 23:01, De Lara Guarch, Pablo:
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> > I have the following errors with Linux 4.0.1:
> >=20
> > lib/librte_eal/linuxapp/kni/igb_main.c:2321:2: error: initializatio=
n from
> > incompatible pointer type
> >   .ndo_bridge_setlink =3D igb_ndo_bridge_setlink,
> >   ^
> > lib/librte_eal/linuxapp/kni/igb_main.c:2321:2: error: (near initial=
ization for
> > =E2=80=98igb_netdev_ops.ndo_bridge_setlink=E2=80=99)
> > lib/librte_eal/linuxapp/kni/igb_main.c: In function =E2=80=98igb_xm=
it_frame_ring=E2=80=99:
> > lib/librte_eal/linuxapp/kni/igb_main.c:5482:2: error: implicit decl=
aration of
> > function =E2=80=98vlan_tx_tag_present=E2=80=99
> >   if (vlan_tx_tag_present(skb)) {
> >   ^
> > lib/librte_eal/linuxapp/kni/igb_main.c:5484:3: error: implicit decl=
aration of
> > function =E2=80=98vlan_tx_tag_get=E2=80=99
> >    tx_flags |=3D (vlan_tx_tag_get(skb) << IGB_TX_FLAGS_VLAN_SHIFT);=

> >    ^
>=20
> I sent a patch for that (kni: fix compilation issue on kernel 4.0.0),=
 by the end of last month.

Oh yes, you're right, sorry.

> Is it OK to merge it or do you want me to send a v4 of this one, incl=
uding that fix?

Separate patches are OK, thanks.