DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: David Hunt <david.hunt@intel.com>, Lee Daly <lee.daly@intel.com>,
	Marcin Hajkowski <marcinx.hajkowski@intel.com>,
	dev@dpdk.org, stable@dpdk.org,
	David Marchand <david.marchand@redhat.com>
Subject: Re: [dpdk-dev] [PATCH] examples/vm_power: fix 32-bit build
Date: Tue, 06 Oct 2020 09:47:07 +0200	[thread overview]
Message-ID: <1757631.4dPmenuF3g@thomas> (raw)
In-Reply-To: <20201005170201.431125-1-ferruh.yigit@intel.com>

05/10/2020 19:02, Ferruh Yigit:
> Compiler version:
> gcc 10.2.1 "cc (GCC) 10.2.1 20200723 (Red Hat 10.2.1-1)"
> 
> Build error:
> ../examples/vm_power_manager/guest_cli/vm_power_cli_guest.c:346:23:
>  warning: format ‘%ld’ expects argument of type ‘long int’, but
> 	argument 4 has type ‘uint64_t’ {aka ‘long long unsigned int’}
> 	[-Wformat=]
>   346 |    cmdline_printf(cl, "Capabilities of [%d] vcore are:"
>       |                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ......
>   349 |      pkt_caps_list.turbo[i],
>       |      ~~~~~~~~~~~~~~~~~~~~~~
>       |                         |
>       |                         uint64_t {aka long long unsigned int}
> 
> Fixes: 07525d1a047a ("examples/vm_power: send capabilities request from guest")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
> Cc: David Marchand <david.marchand@redhat.com>
> Cc: David Hunt <david.hunt@intel.com>
> 
> Fixed patch is not new, not sure why getting the error now but was not
> getting it before, do you have any clue?
> Or is the CI having this error?

Probably because we don't test this example in 32-bit env.
Note: it requires 32-bit libvirt.

Applied with spaces around PRId64, thanks



  reply	other threads:[~2020-10-06  7:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-05 17:02 Ferruh Yigit
2020-10-06  7:47 ` Thomas Monjalon [this message]
2020-10-06  7:47 ` David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1757631.4dPmenuF3g@thomas \
    --to=thomas@monjalon.net \
    --cc=david.hunt@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=lee.daly@intel.com \
    --cc=marcinx.hajkowski@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).