From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f47.google.com (mail-wm0-f47.google.com [74.125.82.47]) by dpdk.org (Postfix) with ESMTP id 95FB62BA0 for ; Fri, 11 Mar 2016 12:21:52 +0100 (CET) Received: by mail-wm0-f47.google.com with SMTP id p65so13403132wmp.0 for ; Fri, 11 Mar 2016 03:21:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=XTaGlR2qlEDAZ+sYlmCDqDiYNl/gmsGFB/9i16vjLpk=; b=DQHoi9v2Jo+IZoMt8/HAcqQqZCFS8X0Vmh4AHwYA5xoEaE68wI5dYXSSOKSUSOnASP 1y+TB4sZuSua/8rI+9GuXMOiM/TOU3yslu5bk8Fd/LIRMof/53NKUHkFWVD4GAfF6GtM k5ds5in9+W8CWsd5EhXtnq2DRp8/dCHIvk2bypmeknyBR6lpG64J8sRSramyigmuUaKu LzIC3RmhQ62xK9fy4ilp+RfPrBb0LvYFxibm86dEq309TcCcB8TyAW0G8bdXDgMDoDF+ IuJBQtH2u+v3TBfHlgLmuUrO96SakQS/x1G4x9E8XL9eYP1xv7oKSk8oAsW49JaGFrYU H0Sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding; bh=XTaGlR2qlEDAZ+sYlmCDqDiYNl/gmsGFB/9i16vjLpk=; b=jyPMO7uweQmIY0bvbW80dre6kKirG+JGmulSEuZhUhnNj/6h9a4gQ3Vkx+QQCQ9OmH sZPBe0/bE4DDnG9UkKmRDwkS9KoUkgXtjZLI8o6re8BXENw4xWYAA99X02zDPKooVZ43 BbceNqHlddfOx+kMirnBJnLXEkGhYIPxi+44QhIUpEuLK2L6twc0ng4sLfosKQEFylqa 8BaMgMDqzaAE58KSWJjVn9flTk52yxHWJsOxPK/UYKfOx5MPGZYb80uXMD2k5IoKDCXn gkCG4SbpTRHt+pydSuqqQKvxBtIVK7OAaod37M5sciJQDG1bJYuSgDyAgU9hZfYyVUj0 R/Tw== X-Gm-Message-State: AD7BkJJ95TYb70YwIwNizQ8ir71/ABOOw6EtFFCSP7nilABZMrup/r0+i4nJ5SUNWU36KEru X-Received: by 10.28.212.85 with SMTP id l82mr2330744wmg.82.1457695312455; Fri, 11 Mar 2016 03:21:52 -0800 (PST) Received: from xps13.localnet (91.111.75.86.rev.sfr.net. [86.75.111.91]) by smtp.gmail.com with ESMTPSA id e4sm1812493wma.10.2016.03.11.03.21.51 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 11 Mar 2016 03:21:52 -0800 (PST) From: Thomas Monjalon To: Panu Matilainen , Helin Zhang Date: Fri, 11 Mar 2016 12:20:09 +0100 Message-ID: <17578435.kLWYh0KOmD@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <56E2A9B5.60605@redhat.com> References: <1457627793-8491-1-git-send-email-helin.zhang@intel.com> <1457686179-20435-2-git-send-email-helin.zhang@intel.com> <56E2A9B5.60605@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v4 1/2] ethdev: add vlan type for setting ether type X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Mar 2016 11:21:52 -0000 2016-03-11 13:19, Panu Matilainen: > On 03/11/2016 10:49 AM, Helin Zhang wrote: > > -int rte_eth_dev_set_vlan_ether_type(uint8_t port_id, uint16_t tag_type); > > +int rte_eth_dev_set_vlan_ether_type(uint8_t port_id, > > + enum rte_vlan_type vlan_type, > > + uint16_t tag_type); > > +int rte_eth_dev_set_vlan_ether_type_v22(uint8_t port_id, uint16_t tag_type); > > +int rte_eth_dev_set_vlan_ether_type_v1604(uint8_t port_id, > > + enum rte_vlan_type vlan_type, > > + uint16_t tag_type); > > > > /** > > * Set VLAN offload configuration on an Ethernet device > > Its nice to see people actually trying to be compatible on occasion :) > > However in this case there's not much point in doing so, because > libethdev ABI has already been broken in this cycle: > http://dpdk.org/browse/dpdk/commit/?id=cfd2279ea6299826fe992028f1dffaf9fa7e7d0a > > In other words, the compatibility versions can never get invoked because > all software built against libethdev needs to be rebuilt anyway because > of the soname bump. Just drop the compat versions, no point carrying > around something that cannot possibly get used. Oh yes, you are right. Sorry Helin for having required that extra work. On the good side, you have learnt how to do it ;)