From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f52.google.com (mail-wm0-f52.google.com [74.125.82.52]) by dpdk.org (Postfix) with ESMTP id ADC538025 for ; Wed, 8 Jun 2016 11:00:02 +0200 (CEST) Received: by mail-wm0-f52.google.com with SMTP id v199so53531811wmv.0 for ; Wed, 08 Jun 2016 02:00:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=BXji38eynhdJk40Ks+YMNCE0G0QQJLP/pfcCOWGYCGQ=; b=lunaoqwNX9xC8iHK2lL7P0PJAzZ9xaTIXW2lttU0yNi+oXehZt+2w5OOIcCRhhkz/y nhWvWDmZfreTvLsxX8me05X7M2k0q6YDrQ9bLUEvub2KGKp2dS4OKFQEoeAXOxSqj0sA nqiSGsbstZHtwuwvZLmDtxD2kT9mcancf5GVB7iYUMZXukealzH32o7DWj4gXgCNpuyT MUS1RsgLF6P69fx/vm5Ai9RAsnZ1e8tfOZt54FRj4f2mror/zqrDJA75V2ZHqiLJ/87h NqDcbZUVUGgRmCuHX0mmp+KZOG+P0aJuoG0CRdn8wHnnVBb42oK4R5n7U3UaC6Xeovxh y8jA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=BXji38eynhdJk40Ks+YMNCE0G0QQJLP/pfcCOWGYCGQ=; b=UvxmuAdHgi3HcnjVrFQ1oI87v17BuKMv68wsyBEUloN8tHDk5AMDtuZOIdm6fr8JIY FL+8dcyfLT+XN+V1EgcGWjglyFYZEnugPfqkxgBbZUlE3L0bGD9LjkWdCNsuPDPECQ99 qtJKqvavfp8BBygaiFMC49Sk5Qksu3eNyYabX4NFaPIreN7UE3R9N7uDW3F/Uli6LQZd JuWQHih0Ov78ZEruRmwiD4jcTT14v3TNTo90pykQ2+h5zF6bJlXdld4yxWrB2njjs05H I36fiM/YOws3sTK7WNhLlU+oBRfAnOFlqN83YLevmtZBmFtmi+xhb4iAz4fEh6cRbhoj lhww== X-Gm-Message-State: ALyK8tLVJ3BKd4opTKyNRgitGHDok7yIZzQHlFDtfj8k8VlakcRGmzp2VhVqSZgl2B8yyegj X-Received: by 10.28.58.6 with SMTP id h6mr3882276wma.101.1465376402387; Wed, 08 Jun 2016 02:00:02 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id kp9sm268054wjb.28.2016.06.08.02.00.01 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 08 Jun 2016 02:00:01 -0700 (PDT) From: Thomas Monjalon To: "Ananyev, Konstantin" , "Lu, Wenzhuo" Cc: dev@dpdk.org Date: Wed, 08 Jun 2016 11:00:01 +0200 Message-ID: <1759174.lsNpYsad2D@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <2601191342CEEE43887BDE71AB97725836B6CC85@irsmsx105.ger.corp.intel.com> References: <1465192093-28651-1-git-send-email-wenzhuo.lu@intel.com> <6A0DE07E22DDAD4C9103DF62FEBC090903483A48@shsmsx102.ccr.corp.intel.com> <2601191342CEEE43887BDE71AB97725836B6CC85@irsmsx105.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] examples: add a new example for link reset X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Jun 2016 09:00:02 -0000 2016-06-08 08:37, Ananyev, Konstantin: > > From: Ananyev, Konstantin > > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wenzhuo Lu > > > > Add a new example to show when the PF is down and up, VF port can be > > > > reset and recover. > > > > > > Do we really need a totally new example for it? > > > Can't we put it in one of already existing ones? > > > Let say we have l3fwd-vf... wouldn't that suit your needs? > > > Konstantin > > I thought about just modifying an existing example. But I choose to add a new one at last. The benefit of a totally new example is we > > can make it simple enough and focus on the reset function. > > So it's easier for the users to find what we want to show. And it's also easier for us as we don't need to care about if our modification > > will break some function of the original example :) > > I still think that adding a new example for esch new feature/function in rte_ethdev API iw way too expensive. > If your change is not good enough and will break original example, then you probably re-work your feature patch > to make it stable enough. > After all people will use it in their existing apps, not write the new ones right? > BTW, why not make it work with testpmd? > After all it is a new PMD api, an that's for we have our testpmd here? +1 for testpmd