From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f169.google.com (mail-wi0-f169.google.com [209.85.212.169]) by dpdk.org (Postfix) with ESMTP id 8BD9A5A35 for ; Tue, 25 Aug 2015 14:04:24 +0200 (CEST) Received: by widdq5 with SMTP id dq5so12868022wid.0 for ; Tue, 25 Aug 2015 05:04:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=0JfygQv02yA9xwnrIE8FneB36bqsUo5bes9inThE2oA=; b=IriFhQa5dKzzXP5fbgIyyetFSzaibtDL7lX9qtxt0cqFyMytgjQkaDtiWWAOi1AT+g CFkgXOJIPw0AC7KfsmBmngz1e0GoxMgBrQpWdLxIPK3wfTWU15N16ZoRbX0vm1Hy5f7K fR8+hnoOTqunLcLVp/J/jIT/QE8R8yTilmX188FeQQePyo/FA188FmgHJlhV0n89Wktz k5Nx0OFXrDk+P/0HXpuyxoqS/ZU6JGeNRqy89XnQNZbGcCfbqaBuCOJdgmT3N9XInKeD VKw9FUHq+d1c8SUWobhIKFt2kt67j0yWSCbHiv5KnhvvTtuo88RPAFx/ECg0qKirwuqg KuWw== X-Gm-Message-State: ALoCoQkTZI87+lFZeYYobaWLAPKkCwH5AE5ihhT8j8bOUAzIyee2H/y40p4//eMiCMGwASDhQYUs X-Received: by 10.194.93.3 with SMTP id cq3mr49621392wjb.20.1440504264301; Tue, 25 Aug 2015 05:04:24 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id nb10sm2351840wic.11.2015.08.25.05.04.23 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 25 Aug 2015 05:04:23 -0700 (PDT) From: Thomas Monjalon To: dev@dpdk.org, Jerin Jacob Date: Tue, 25 Aug 2015 14:03:13 +0200 Message-ID: <1759749.jiktJN44xV@xps13> Organization: 6WIND User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; ) In-Reply-To: <1439901605-31164-4-git-send-email-jerin.jacob@caviumnetworks.com> References: <1439901605-31164-1-git-send-email-jerin.jacob@caviumnetworks.com> <1439901605-31164-3-git-send-email-jerin.jacob@caviumnetworks.com> <1439901605-31164-4-git-send-email-jerin.jacob@caviumnetworks.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 3/3] app/test: enable test_red to build on non x86 platform X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Aug 2015 12:04:24 -0000 2015-08-18 18:10, Jerin Jacob: > --- a/app/test/test_red.c > +++ b/app/test/test_red.c > +#if defined(RTE_ARCH_X86_64) || defined(RTE_ARCH_I686) || defined(RTE_ARCH_X86_X32) > #ifdef __PIC__ > asm volatile ( > "mov %%ebx, %%edi\n" > @@ -155,6 +156,7 @@ static inline void rdtsc_prof_start(struct rdtsc_prof *p) > #else > asm( "cpuid" : : : "%eax", "%ebx", "%ecx", "%edx" ); > #endif > +#endif > p->clk_start = rte_rdtsc(); The right fix would be to move that arch-specific code into an EAL abstraction.