From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6A033A0C4E; Mon, 25 Oct 2021 17:02:05 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DA3EC40E32; Mon, 25 Oct 2021 17:02:04 +0200 (CEST) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by mails.dpdk.org (Postfix) with ESMTP id 2B26F4003E for ; Mon, 25 Oct 2021 17:02:03 +0200 (CEST) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 96B585C019C; Mon, 25 Oct 2021 11:02:00 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Mon, 25 Oct 2021 11:02:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= zKVMb9qvbzUr0sYo7Tb8jAMPmdW5GYuSBOvDjPIzKWs=; b=Akfz6gPIkdMO38B7 t9F6dKSMD3FWvtsMMi7rm2wuCdsvRGoER3WoR9pvtXvHr9lW4N8Y8TjN/OPLtvjc mwaPuDwfd6IE9oeciwEYpJ11f262QPjfv7fMW8XsUvQ3q20bOwaip+DoCmOrRyrL cAOfI3Emz2BGAcd71M5rz8478x82zMpVTpghDiOjVB0ty9Ba1ft+lzBs2AEHTjcd /WKbyPmbPoXbYsnrvCT4QKM86MoHGNufRif7enedkVdzk2No+aAoIaKa9rqcug2A fWV86P/ZJXnXmzWofv7rI/P480b5R5vZ0bc+PISxRyAUhCzgPxI6li62IySlfOPQ d/l6mg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=zKVMb9qvbzUr0sYo7Tb8jAMPmdW5GYuSBOvDjPIzK Ws=; b=idUfHFMNlS7sLJ0brBH+YNqwZMPORUb3goCxfD3Wzkk/tiqZ1b3tYPR3w YSBUqbvjpgp5dEiWjM2oU7DvBiQpdSnzGMof0ZwW/zX1OzhX/vNCasH66Z967w5m LcM4yQD5kN66vsY7W49OaU2wsKxomFPjsnR72DztqcsKlNgzyffbfC7NzCukZx83 mD3rt/FPuIkONFM/bM09bjRpka/XPKU7Zn1VpGtrrew7fQDu5FG5v0Y8L7l26R0K eO/+6LoDq1g43ZTeOscIqEckNAC83xyaCYscDr/1c/iVZ1BERVrz7pky9s+0ihlX hdDB8cOZpuWRSzckRtEuMUlHng6Qg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrvdefhedgkedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 25 Oct 2021 11:01:58 -0400 (EDT) From: Thomas Monjalon To: Dmitry Kozlyuk Cc: dev@dpdk.org, Andrew Rybchenko , Olivier Matz Date: Mon, 25 Oct 2021 17:01:56 +0200 Message-ID: <1762225.NsIPjj5ZNk@thomas> In-Reply-To: References: <20211022075937.52983-1-dkozlyuk@nvidia.com> <20211022210920.207732-1-dkozlyuk@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] mempool: fix non-IO flag inference X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 25/10/2021 15:33, Olivier Matz: > On Sat, Oct 23, 2021 at 12:09:19AM +0300, Dmitry Kozlyuk wrote: > > When mempool had been created with RTE_MEMPOOL_F_NO_IOVA_CONTIG flag > > but later populated with valid IOVA, RTE_MEMPOOL_F_NON_IO was unset, > > while it should be kept. The unit test did not catch this > > because rte_mempool_populate_default() it used was populating > > with RTE_BAD_IOVA. > > > > Keep setting RTE_MEMPOOL_NON_IO at an empty mempool creation > > and add an assert for it in the unit test (remove the separate case). > > Do not reset the flag if RTE_MEMPOOL_F_ON_IOVA_CONTIG is set. > > > > Fixes: 11541c5c81dd ("mempool: add non-IO flag") > > > > Signed-off-by: Dmitry Kozlyuk > > Acked-by: Olivier Matz Applied, thanks.