From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <thomas@monjalon.net> Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 071FF1B485 for <dev@dpdk.org>; Wed, 10 Oct 2018 11:35:32 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 9B7E621949; Wed, 10 Oct 2018 05:35:31 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Wed, 10 Oct 2018 05:35:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=kqaFyj8HeXgYqDi7LljNfCKPHkLJ+obVFLBYwQ8z9Ig=; b=LvWCX51OXWXT pGoS4sFoL/J0pQ13QAPeWr5RahSc1JBBosEYzRe7L3l0GOmhy9vjCEEgeh9elIbG 87Ht1O0MDKjeZcPMptABICZmviU/nDDHSJ78I0mdh8YeuPbTRIjQzBA46NMitAcy Ii/H+PgewEbXjeK2HiDQK5ts/zaosmQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=kqaFyj8HeXgYqDi7LljNfCKPHkLJ+obVFLBYwQ8z9 Ig=; b=Kkzb7I/V0yV+bGRR/rDkXLvzV7NiCqNAuqGi/IozYMU6btHdm+pRH5nCQ 0PrnPcMEACIVHpnc7zTfwROUDYyl2t73ri9hiEv+tfvmVlUBHc5VfxxKyn8mvNQJ 58HEIjKIk3A7+q5dr0y42I8vWbHFG7C2DStrUTjnq7EBDC15OPenAjeTBfGFjCF0 cBhJ8H+fDD5+iEoVVaHXlPiUOf7QOVcYdFCLyiGkv1DZdeFnQWTp+X8o9PCsoy4Y JcNmJDyhHRg5pTDp2D2Kzoka/GmxxWAHADGlaOBl94Wcp0Z5SSdZ03Iy8bJr9PXU cm0ifCkmiP8sP0YUDxPnNZAG1hOJA== X-ME-Sender: <xms:4se9W_Nl0UnHnopvM6U4KaCvBXgjOxDMM6tS-oJP58sFNFxizzqsmA> X-ME-Proxy: <xmx:4se9WzPExIsvIjOSoiVLThWYReDqaK79GqkNoL0NieHlZxfT9xlKvw> <xmx:4se9W50u9lpcWKn51K9WTv0nt6zLscG44AGm9dmxFZ91ZGGw6fZISg> <xmx:4se9W_QBOtdYiCvw2TzeKW2sHjnQW_J-5nyw6QrhnvRPGYkNFourVg> <xmx:4se9W8l3leNcTN5hE_cT2baPk2TBRhfExBH3-_ylDMMR2zEUIZyPvQ> <xmx:4se9WwPQ37O1UmnrC20KW6SLdujE1l3V8V7oss0Bc5XDitZgbSBwKA> <xmx:48e9W_7bIl7yY4n5HtOIhiJRyMbPAAQuepBmFH_22WgJN6bwceT-YA> Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 30A5F102E9; Wed, 10 Oct 2018 05:35:30 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: Andrew Rybchenko <arybchenko@solarflare.com> Cc: dev@dpdk.org, ferruh.yigit@intel.com Date: Wed, 10 Oct 2018 11:35:28 +0200 Message-ID: <1764273.HaIcP3AaDl@xps> In-Reply-To: <6dbbefd9-1677-1233-0f7d-0988410b7157@solarflare.com> References: <1539157900-6208-1-git-send-email-arybchenko@solarflare.com> <9285291.oQvEkmlzME@xps> <6dbbefd9-1677-1233-0f7d-0988410b7157@solarflare.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [RFC PATCH 2/3] ethdev: advertise default MAC as retained on device restart X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Wed, 10 Oct 2018 09:35:32 -0000 10/10/2018 11:05, Andrew Rybchenko: > On 10/10/18 11:53 AM, Thomas Monjalon wrote: > > 10/10/2018 09:51, Andrew Rybchenko: > >> The documentation says MAC addresses array is retained and > >> it is logical to assume that default MAC address is retained > >> as well. > > I'm confused. Default MAC address isn't implied by MAC addresses array? > > From API point of view it looks as different features (at least for me): > - default MAC address is rte_eth_dev_default_mac_addr_set() > - MAC addresses array is > rte_eth_dev_mac_addr_add()/rte_eth_dev_mac_addr_remove() > but it is under one umbrella in NIC features (Unicast MAC filter). Because default MAC address is mac_addrs[0]. > May be it is my misunderstanding. More doc is better :) If it can be thought as different features, let's document it as you do.