From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id CA9EF1B6C7 for ; Wed, 10 Oct 2018 16:43:17 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 7D1BD21D07; Wed, 10 Oct 2018 10:43:16 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 10 Oct 2018 10:43:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=Y9ahZ9ru5NcZaqh6g4f6zSawh1kze4RTuX6CbjzCSJ0=; b=mCCiSdig87oA 8E6tUllyxOSQAabOC4MkVjDRiqL7G8m/bL6O3wTmxo6HCv7ky1xyYfFTxVWfY1Bz fJPWln8RIVQBdfgWZLoZTAVf2UIn3syInGkKXpo+qS4wtII3xG5bQHy0wCSEcwux W3+zfktSVo2ZM2AoccFyOcfVtOMl6EU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=Y9ahZ9ru5NcZaqh6g4f6zSawh1kze4RTuX6CbjzCS J0=; b=c3of9evlA46Yxj72Pac+Fc/fGvZ+48vUqIacuTaStz6MaUggSrlldRfyh OSwh3AynmM/Q+WuRGrOBW/KVI+k8TjTBNS9OpZVjce0GL/sEhhqnEXrV0SLwdNvV 21oPUmUou8hdLaqfKiYih5TN9RftL/POrEa4DBBuASMuvb2SVWpe6CoLcxEr2AbB iSbsP1Ib/vDkVJmsXkaTuVdSws2Pv83U2LEy1239jtEuZEIknyAavYO6Q1feNCfh aWLqbKu2OcjU+50Zq0qC5WzoOMaEaAfLr1VIORLP8V5h2vhqPTTYSZq0MhmYMh4y H/kjXKxUCn+tOYyEV2SDLNYg45LtA== X-ME-Sender: X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 3C57BE48BD; Wed, 10 Oct 2018 10:43:15 -0400 (EDT) From: Thomas Monjalon To: Neil Horman Cc: dev@dpdk.org, Ferruh Yigit Date: Wed, 10 Oct 2018 16:43:14 +0200 Message-ID: <1766289.2YrT9N83Jn@xps> In-Reply-To: <20181010142928.11274-1-nhorman@tuxdriver.com> References: <20181010142928.11274-1-nhorman@tuxdriver.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] check-experimental-syms.sh: prevent symbol matches on substrings X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Oct 2018 14:43:18 -0000 10/10/2018 16:29, Neil Horman: > Thomas attempted to submit this: > https://patches.dpdk.org/patch/46311/ > > The other day, because the other patches being submitted with it were > breaking on a false positive from the check-experimental-syms check. > > The problem was that the experimental symbol check script matched on the > regexs "\.text.*$SYM" and "\.text\.experimental.*$SYM" which allows for > substring matches, and librte_ethdev recently introduced symbols that > are leading substrings of one another (e.g. symbol foo is a substring of > symbol foobar), and so we would match on symbols when we shouldn't > > Instead of dropping the check, fix this properly by matching > additionally on the end of line so that symbols are an exact match. > > Confirmed to build properly on Thomas' submitted patch set with the > experimental check patch reverted (so that the checking actually > happens) That's great Neil! I would like to push it now. May I suggest to remove the details of how I (baldly) reported it? I suggest this text: " The experimental symbol check script matched on the regexes "\.text.*$SYM" and "\.text\.experimental.*$SYM" which allows for substring matches. If a symbol is leading substring of another one (e.g. symbol foo is a substring of symbol foobar), it would match on symbols when it shouldn't. It is fixed by matching additionally on the end of line so that symbols are an exact match. "