From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id 041C9262E for ; Thu, 20 Sep 2018 15:25:51 +0200 (CEST) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us4.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id 398CEBC0080; Thu, 20 Sep 2018 13:25:50 +0000 (UTC) Received: from [192.168.38.17] (91.220.146.112) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 20 Sep 2018 14:25:05 +0100 To: Ferruh Yigit , Gaetan Rivet CC: , Ian Dolzhansky References: <1535526966-32456-1-git-send-email-arybchenko@solarflare.com> <1535526966-32456-2-git-send-email-arybchenko@solarflare.com> From: Andrew Rybchenko Message-ID: <17685282-d492-479e-6fa9-33c17d5328a0@solarflare.com> Date: Thu, 20 Sep 2018 16:24:19 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-GB X-Originating-IP: [91.220.146.112] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24106.003 X-TM-AS-Result: No-10.947800-8.000000-10 X-TMASE-MatchedRID: y/2oPz6gbvgOwH4pD14DsPHkpkyUphL94cLBHAw1BRYs/uUAk6xP7PlY oV6p/cSxb26KMr8OMtO/08jbUug8/L4VhlZ3FziRQpxiLlDD9FX7At+An9uo8y8zQZ2rR/Opu6H OfkJCGYFfcTZ8crFLkqV14bUzS8PitbDEh7FAI+BIRA38P/dwblg3VqSTJ7So0apUEpjsc8HzTu 35URal5iBkhyrvdMSlklPOPDP4bOjHuFqMm/pFRcg6fo0rxLVrJd2n2XoSRFnnZVNiuSZvWyzJW Grzf/lSNTcc+FGtHL0Ojb0PL1TpnN9faxl/I4mhngIgpj8eDcC063Wh9WVqgtQdB5NUNSsi1GcR AJRT6PMFlVldG0WxKMxgBfQsFbubqrUVAk656pHFO8pW9TnUmyRK28yMSz4ugYuFWcbbXTRj49U rjZY+e9JUFivqOnezmrBZkEtECNeQCK4DIKB5gg== X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--10.947800-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24106.003 X-MDID: 1537449951-0bRCnYuF-jTb Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH 1/4] app/testpmd: add queue deferred start switch X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Sep 2018 13:25:52 -0000 On 9/3/18 7:56 PM, Ferruh Yigit wrote: > On 8/29/2018 8:16 AM, Andrew Rybchenko wrote: >> From: Ian Dolzhansky >> >> Signed-off-by: Ian Dolzhansky >> Signed-off-by: Andrew Rybchenko >> --- >> app/test-pmd/cmdline.c | 91 ++++++++++++++++++++++++++ >> doc/guides/rel_notes/release_18_11.rst | 6 ++ >> 2 files changed, 97 insertions(+) >> >> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c >> index 589121d69..f47ec99f1 100644 >> --- a/app/test-pmd/cmdline.c >> +++ b/app/test-pmd/cmdline.c >> @@ -883,6 +883,10 @@ static void cmd_help_long_parsed(void *parsed_result, >> " Start/stop a rx/tx queue of port X. Only take effect" >> " when port X is started\n\n" >> >> + "port (port_id) (rxq|txq) (queue_id) deferred_start (on|off)\n" >> + " Switch on/off a deferred start of port X rx/tx queue. Only" >> + " take effect when port X is stopped.\n\n" > Overall looks good to me. > > But testpmd doc needs to be updated to add new command. > doc/guides/testpmd_app_ug/testpmd_funcs.rst Will fix in v2 > Also is there a way to see the current deferred_start status of a port, either > with a specific command or as part of other command like "show port info"? > If not does it make sense to have a way to see it? The following command does it: show rxq|txq info Thanks, Andrew.