DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] mk: allow application to override clean
Date: Fri, 30 Jan 2015 11:46:07 +0100	[thread overview]
Message-ID: <1768599.JE1HSW6J0Q@xps13> (raw)
In-Reply-To: <20150129223641.75306372@uryu.home.lan>

2015-01-29 22:36, Stephen Hemminger:
> On Thu, 29 Jan 2015 02:52:45 -0800
> Thomas Monjalon <thomas.monjalon@6wind.com> wrote:
> 
> > Hi Stephen,
> > 
> > 2015-01-28 12:00, Olivier MATZ:
> > > Hi Stephen,
> > > 
> > > On 01/23/2015 07:19 AM, stephen@networkplumber.org wrote:
> > > > From: Stephen Hemminger <shemming@brocade.com>
> > > >
> > > > In some cases application may want to have additional rules
> > > > for clean. This can be handled by allowing the double colon
> > > > form of rule.
> > > >
> > > >   https://www.gnu.org/software/make/manual/html_node/Double_002dColon.html
> > > 
> > > There is already a way to do that in dpdk makefiles: you can add
> > > the following code in your application Makefile, before the line
> > > that includes $(RTE_SDK)/mk/rte.app.mk:
> > > 
> > > POSTCLEAN += my_clean
> > > 
> > > .PHONY: my_clean
> > > my_clean:
> > > 	@echo executed after clean
> > 
> > Does it fit with your needs?
> > Should we revert your patch? Double-colon rules were avoided in DPDK.
> > "Double-colon rules are somewhat obscure and not often very useful"
> > 
> 
> Works for me.

So the commit is now reverted:
	http://dpdk.org/browse/dpdk/commit/?id=785e1a0932b67136

-- 
Thomas

      parent reply	other threads:[~2015-01-30 10:46 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-23  6:19 stephen
2015-01-27 11:58 ` Thomas Monjalon
2015-01-28 11:00 ` Olivier MATZ
2015-01-29 10:52   ` Thomas Monjalon
2015-01-29 17:07     ` Mcnamara, John
     [not found] ` <1902752B0C92F943AB7EA9EE13E2DEEC287AE6B39E@HQ1-EXCH02.corp.brocade.com>
     [not found]   ` <20150129223641.75306372@uryu.home.lan>
2015-01-30 10:46     ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1768599.JE1HSW6J0Q@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=dev@dpdk.org \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).