From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-we0-f176.google.com (mail-we0-f176.google.com [74.125.82.176]) by dpdk.org (Postfix) with ESMTP id 821DA255 for ; Fri, 30 Jan 2015 11:46:35 +0100 (CET) Received: by mail-we0-f176.google.com with SMTP id w62so26349151wes.7 for ; Fri, 30 Jan 2015 02:46:34 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=GeJEDPDcdhNFKN2LSlSqQ3bVT8ZLVg03WeDQN/dfdrQ=; b=Ki4TiOWBwkyxq4o0INKZ1l3G8FvUsGYO15irudIULzlbksBvEx2o0H31pKUlGF20Dh 3oIZeUaxW0pL/4rDAS/Plzs3uqJTqi+sYoXPQuey3pdHf1RdDZbiljA8cwTqfT3j1W/K ij9tGSUpyGHSy+/VEGGscdmmlJj5B64foOpYpZsLPGVvNcTcv9gvs1dnckGxdN0vKe/s ebYyzPqPuxj/kBTOklq6yDS5y5f8oSZHs0yFnz0hnfrrsjOvmqm9ptINJiv94jRf+0oJ 29SEcs8eVTbENERyK24SRHwPBxfRbQ73NZUvioK5iEbYM1jYYtNIlvIu5uP5KUvj+Hsw 8ehw== X-Gm-Message-State: ALoCoQnOrZd6sair+q05hwNCRlFRljPOz55pKBkdKpVGp3Z5Kz0OQ+A3DbkHOkRN6XJ3V0kTdawn X-Received: by 10.194.175.39 with SMTP id bx7mr10952582wjc.22.1422614794417; Fri, 30 Jan 2015 02:46:34 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id mx4sm6342197wic.24.2015.01.30.02.46.33 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 30 Jan 2015 02:46:33 -0800 (PST) From: Thomas Monjalon To: Stephen Hemminger Date: Fri, 30 Jan 2015 11:46:07 +0100 Message-ID: <1768599.JE1HSW6J0Q@xps13> Organization: 6WIND User-Agent: KMail/4.14.4 (Linux/3.18.4-1-ARCH; KDE/4.14.4; x86_64; ; ) In-Reply-To: <20150129223641.75306372@uryu.home.lan> References: <1421993948-24785-1-git-send-email-stephen@networkplumber.org> <1902752B0C92F943AB7EA9EE13E2DEEC287AE6B39E@HQ1-EXCH02.corp.brocade.com> <20150129223641.75306372@uryu.home.lan> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] mk: allow application to override clean X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Jan 2015 10:46:36 -0000 2015-01-29 22:36, Stephen Hemminger: > On Thu, 29 Jan 2015 02:52:45 -0800 > Thomas Monjalon wrote: > > > Hi Stephen, > > > > 2015-01-28 12:00, Olivier MATZ: > > > Hi Stephen, > > > > > > On 01/23/2015 07:19 AM, stephen@networkplumber.org wrote: > > > > From: Stephen Hemminger > > > > > > > > In some cases application may want to have additional rules > > > > for clean. This can be handled by allowing the double colon > > > > form of rule. > > > > > > > > https://www.gnu.org/software/make/manual/html_node/Double_002dColon.html > > > > > > There is already a way to do that in dpdk makefiles: you can add > > > the following code in your application Makefile, before the line > > > that includes $(RTE_SDK)/mk/rte.app.mk: > > > > > > POSTCLEAN += my_clean > > > > > > .PHONY: my_clean > > > my_clean: > > > @echo executed after clean > > > > Does it fit with your needs? > > Should we revert your patch? Double-colon rules were avoided in DPDK. > > "Double-colon rules are somewhat obscure and not often very useful" > > > > Works for me. So the commit is now reverted: http://dpdk.org/browse/dpdk/commit/?id=785e1a0932b67136 -- Thomas