From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8DDE5A04F1; Thu, 18 Jun 2020 22:32:20 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0FE941C025; Thu, 18 Jun 2020 22:32:20 +0200 (CEST) Received: from mail-qt1-f194.google.com (mail-qt1-f194.google.com [209.85.160.194]) by dpdk.org (Postfix) with ESMTP id 6D5051BFFC for ; Thu, 18 Jun 2020 22:32:19 +0200 (CEST) Received: by mail-qt1-f194.google.com with SMTP id w90so5551272qtd.8 for ; Thu, 18 Jun 2020 13:32:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=aZVA7fndZVFkHu0RWpDdFOBTiE4ctPa2RMGJiZkYbqI=; b=i5B92qhIuAwhYO/Kclb+z1AP5iTgkYFM+cvJCzIVqpkaPX2NJttl+jfy7w2IuwOmHY 25p8V2hqlDrjYEZtA7V9bHbzp/JEud+Jn/M89Z8hMRIUm10sdRFi+roSb56pP84J5KvO v3AZtc5WN3fjIvajJsWhQPf7NCtv/65QBxnekMo5mybCZ1JcLqJuwibRHuTAwPHx6bLA r7VLghh3ZdfXJ4cyxDWJM6dRjk307Ar1547Wq2H/KBN7yaM2/5hhBEGirx6nyIveBYRj 5OFHUr9lFuUNp6oGukYPjKrGJVkW4ha3cpwA/aMEDtAkPI4lyDlLS0RcGpdn1FoJ7vFo 4hkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=aZVA7fndZVFkHu0RWpDdFOBTiE4ctPa2RMGJiZkYbqI=; b=q6JAkNfWXfAl8j2F3B6/YoU5FeglcydW7NQwh+Fiza0KxkedDE8UCNyu/vLyZXybYf mIUsAfoMU0u1bSQfjQf46rlG7FqWWEpvkpL1xvZc56dWWQszO1Ds7vSLM+QfQGLqq+S+ WVdlFJj1SXhqjyQhscMncOc9/Xol0Lwkq9onsOoFziz682Ih/nuRjygXcSxXt1AU4qib 0q87Nhi8XvOhfb1/OO2frUOA+oEBP+RIBCmP49r8JWvV/vYmiL1gbqXhCGaPmBAFLlfl y7HkiIXtqUfoRtZyfro+przbwzGoK/WOvn2yxgur2mAQ5WZsvpCznlDPcNmTQ7rb8Cjr pwnQ== X-Gm-Message-State: AOAM530hOh7kSMRg3ETGGMo8fBT8od7Z65/NEPp7wfxXFj9O7iqN3cTp u4nN3zzKbGFnivd8zT59r0sXwmZp X-Google-Smtp-Source: ABdhPJwgGxXplopCGuDGcMSW6oKrsotNDBsyHFkwWul8/HetwLdTxhLQIAy0IbBizVhg2KZbEtdfEg== X-Received: by 2002:ac8:34e8:: with SMTP id x37mr4192262qtb.291.1592512338632; Thu, 18 Jun 2020 13:32:18 -0700 (PDT) Received: from [192.168.1.10] (pool-96-255-60-31.washdc.fios.verizon.net. [96.255.60.31]) by smtp.gmail.com with ESMTPSA id k6sm4167540qte.52.2020.06.18.13.32.17 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 18 Jun 2020 13:32:18 -0700 (PDT) To: dev@dpdk.org References: <20200617190248.25858-1-log0div0@gmail.com> From: Chas Williams <3chas3@gmail.com> Message-ID: <1768cd54-65a0-5fca-ef3f-418429a1ea3d@gmail.com> Date: Thu, 18 Jun 2020 16:32:17 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20200617190248.25858-1-log0div0@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] pmd_bond: fix mac address update for ACTIVE_BACKUP, TLB and ALB modes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Yes, this does look like a typo on someone's part. Please change use net/bonding: instead of pmd_bond: Please add a Fixes: line Please add a Cc: stable@dpdk.org On 6/17/20 3:02 PM, Sergey Lvov wrote: > It seems to be a typo > > Signed-off-by: Sergey Lvov > --- > drivers/net/bonding/rte_eth_bond_pmd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c > index 612a64599..3ef0df84a 100644 > --- a/drivers/net/bonding/rte_eth_bond_pmd.c > +++ b/drivers/net/bonding/rte_eth_bond_pmd.c > @@ -1533,7 +1533,7 @@ mac_address_slaves_update(struct rte_eth_dev *bonded_eth_dev) > if (internals->slaves[i].port_id == > internals->current_primary_port) { > if (rte_eth_dev_default_mac_addr_set( > - internals->primary_port, > + internals->current_primary_port, > bonded_eth_dev->data->mac_addrs)) { > RTE_BOND_LOG(ERR, "Failed to update port Id %d MAC address", > internals->current_primary_port); >