From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wi0-f170.google.com (mail-wi0-f170.google.com
 [209.85.212.170]) by dpdk.org (Postfix) with ESMTP id C8438803A
 for <dev@dpdk.org>; Thu,  4 Dec 2014 14:37:40 +0100 (CET)
Received: by mail-wi0-f170.google.com with SMTP id bs8so36176226wib.3
 for <dev@dpdk.org>; Thu, 04 Dec 2014 05:37:40 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=wbzm9T+ZATRGM67okRWJ3E1mXIrQhi+v6Phf5plARPY=;
 b=UGuDpIIlUmo77NnsZX+hYsEfv0O6T0rpMMYxajXX2LI6lwdhN1M+hyeQB57DX+W4RH
 JrNsBwPuE9++ovnqmnXuC5TppjyihE7M1Ze1m2lpmtouYUANOjPuaXloyekH6neT0clA
 P7EIpqGgi320Y4WQnUASxYJXWXLN3prS9mzYyYnY3QZyp7jafe6s5kjYiu3RlkcFeymn
 dlH8hgkmrYOIuoHtSme67qnQiN5uBo4ejDf+oHDi2RtRu9aPKCYr8qz0qrHb4nKni3vi
 oEOnzMdlGXVZsUgr+c3cb/TU624Y6p6R+2cqH7ma/yRnAscJ9b59/iY8m7/1hXxLU3uP
 GZtQ==
X-Gm-Message-State: ALoCoQki1dLToszNc5YtQVh2wfwT6tV1RlqAdUiOMLQLQNckbtLLtZx5fnSzW68dQF8hrvk2ZlOa
X-Received: by 10.180.20.50 with SMTP id k18mr21935727wie.31.1417700260681;
 Thu, 04 Dec 2014 05:37:40 -0800 (PST)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by mx.google.com with ESMTPSA id h14sm41393418wic.8.2014.12.04.05.37.39
 for <multiple recipients>
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Thu, 04 Dec 2014 05:37:39 -0800 (PST)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Date: Thu, 04 Dec 2014 14:37:15 +0100
Message-ID: <1770523.OPzYA99vBi@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.3 (Linux/3.17.4-1-ARCH; KDE/4.14.3; x86_64; ; )
In-Reply-To: <1417625819-3024-1-git-send-email-bruce.richardson@intel.com>
References: <1417625819-3024-1-git-send-email-bruce.richardson@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] examples: fix symmetric_mp,
	set NIC rx_drop_en bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 04 Dec 2014 13:37:40 -0000

2014-12-03 16:56, Bruce Richardson:
> The symmetric_mp example app is set up to allow two processes to
> share a NIC port, with each pulling packets from one queue. In order
> to have the app continue working when one of the process dies, the
> drop_en bit should be set in the NIC configuration. Without this bit
> set, the NIC will stall once any queue fills. With the bit set, once
> a queue fills, all subsequent packets for that queue are discarded
> allowing other queues to continue operating as normal.
> 
> This setting was missed when converting to use standardised defaults
> in commit 81f7ecd9.

I don't see rx_drop_en in commit 81f7ecd9.
Why do you say it was missed?

-- 
Thomas