From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 2C58C559A;
 Sat, 27 Oct 2018 17:13:06 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id C33D821C1C;
 Sat, 27 Oct 2018 11:13:05 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
 by compute1.internal (MEProxy); Sat, 27 Oct 2018 11:13:05 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding:content-type; s=mesmtp;
 bh=y/BVcT2uAmq2XTJStjql6/UR7NFg9MNkIhbLkSezUEA=; b=r4shCXlU4COH
 Ap+1mkfwZJepTWgoyaUuekzUihIDTZZUHcn8EH7C1URQjBeBnDk4iMaWqgyycnX6
 d0nLY3cFwx2TTQwepN4PoHxYC5OwcoIV5bUdlIt6SitrlDWefw0vFFd+3/AK1MlA
 sIeZwmeex/FDU/oSW3kZvNO7sXPxYmU=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
 :x-sasl-enc; s=fm1; bh=y/BVcT2uAmq2XTJStjql6/UR7NFg9MNkIhbLkSezU
 EA=; b=SrbF3/Nc5u2Q+kzMeG5bTAlZYSYNhAVXal5ln5PBnZtJAqA6Nf/qz8ySc
 pdOebr5xbVfsKusVfvK5Zwl4PUqAI4OWxzjjXWCFifxfkuvWEklf2vbl7U7nB0+B
 fbWuKKNv5Mlnfc7rpsjzKhHkjX0fPE7y3acKlQRdks106FG0sXthbYZ6Xim1W6GI
 aGkIeH6HGtb4kslN3ipjjn6MFVjolLT0yDzPqPIviZ4AL/WRwIuIRxIAE/ZTXx2D
 4CVam6f8XhKykHJEh7Oyl+BWQtOTqWIh7Y0MEfKtPyiRE72ak++vXTRvb8JTLBc4
 hS6HENuI3s4J6ON3N2i6env1bAB3Q==
X-ME-Sender: <xms:gIDUWzTUwMmR7Bxvl719cQvwa1pNzo8Z9iTV7YjlAX3OFGyn69vuqg>
X-ME-Proxy: <xmx:gYDUW5LepHWki3QNBrP0g6MLsmpwlaYeHP6CC4-jpuLNgPNNyEUfTA>
 <xmx:gYDUW3b0jwCmlEoITuwBDsUozAFQMNx7L-ukqn8YKQ9ffzsJ1J1E1A>
 <xmx:gYDUWz_2-C5qwZQ8WKU2LTFG1pzh2lLr0PWUYTTx88K4WNMHlsOx_Q>
 <xmx:gYDUWwbhAOCE16J4lAcGFXoy2YTi9N_H2-pdKrfe6xOn20mWplC16g>
 <xmx:gYDUW_MHyBfrhoY7uiPq3Lt7QFrN8K7inIjfSMEne0RpAqKDbM_gCQ>
 <xmx:gYDUW8hAHCyfldVj2EvFXF2svMULlZAvX3V4iNPtXr0YtOQ2WDAQBQ>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id D019A102E9;
 Sat, 27 Oct 2018 11:13:03 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Cc: "Gavin Hu (Arm Technology China)" <Gavin.Hu@arm.com>,
 "dev@dpdk.org" <dev@dpdk.org>,
 Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>,
 "stable@dpdk.org" <stable@dpdk.org>, Ola Liljedahl <Ola.Liljedahl@arm.com>,
 "olivier.matz@6wind.com" <olivier.matz@6wind.com>,
 "chaozhu@linux.vnet.ibm.com" <chaozhu@linux.vnet.ibm.com>,
 "bruce.richardson@intel.com" <bruce.richardson@intel.com>,
 "konstantin.ananyev@intel.com" <konstantin.ananyev@intel.com>
Date: Sat, 27 Oct 2018 17:13:10 +0200
Message-ID: <17713879.gC9jYcxDUo@xps>
In-Reply-To: <20181027150024.GA2294@jerin>
References: <1537172244-64874-2-git-send-email-gavin.hu@arm.com>
 <1874944.OrACW1nkDZ@xps> <20181027150024.GA2294@jerin>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH 1/2] ring: synchronize the load and store of
	the tail
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Sat, 27 Oct 2018 15:13:06 -0000

27/10/2018 17:00, Jerin Jacob:
> From: Thomas Monjalon <thomas@monjalon.net>
> > 17/10/2018 08:35, Gavin Hu (Arm Technology China):
> > > Hi Jerin
> > >
> > > As the 1st one of the 3-patch set was not concluded, I submit this 2-patch series to unblock the merge.
> > 
> > The thread is totally messed up because:
> >         - there is no cover letter
> >         - some different series (testpmd, i40e and doc) are in the same thread
> >         - v4 replies to a different series
> >         - this version should be a v5 but has no number
> >         - this version replies to the v3
> >         - patchwork still shows v3 and "v5"
> >         - replies from Ola are not quoting previous discussion
> > 
> > Because of all of this, it is really difficult to follow.
> > This is probably the reason of the lack of review outside of Arm.
> > 
> > One more issue: you must Cc the relevant maintainers.
> > Here:
> >         - Olivier for rte_ring
> >         - Chao for IBM platform
> >         - Bruce and Konstantin for x86
> > 
> > Guys, it is really cool to have more Arm developpers in DPDK.
> > But please consider better formatting your discussions, it is really
> > important in our contribution workflow.
> > 
> > I don't know what to do.
> > I suggest to wait for more feedbacks and integrate it in -rc2.
> 
> This series has been acked and tested. Sure, if we are looking for some
> more feedback we can push to -rc2 if not it a good candidate to be
> selected for -rc1.

It has been acked and tested only for Arm platforms.
And Olivier, the ring maintainer, was not Cc.

I feel it is not enough.