From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1ED67A00C2; Wed, 2 Nov 2022 16:47:26 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 022E840223; Wed, 2 Nov 2022 16:47:26 +0100 (CET) Received: from new4-smtp.messagingengine.com (new4-smtp.messagingengine.com [66.111.4.230]) by mails.dpdk.org (Postfix) with ESMTP id 0A18A40041 for ; Wed, 2 Nov 2022 16:47:25 +0100 (CET) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailnew.nyi.internal (Postfix) with ESMTP id 5359058033E; Wed, 2 Nov 2022 11:47:24 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Wed, 02 Nov 2022 11:47:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1667404044; x= 1667411244; bh=4IBWSvy4lxlXHSuY+tjexTOB1Q3vxjtYOhhT6BxakwU=; b=b c+2A+orGOQRyahKCu8+xrQ5msdpUoAEdu0YBSeZDs9+MOQib1JhJmE+aHuK1OXGE oeethd3q42RRwFwLn1XbnGJmiqbmQ6onEzNigxzBsur8SOtDHERlQsTDfzM3j5hI C3Q/St/yJ4wU1fs2RYMU2YOZWQnOtlLrjxePnewPd/Wf2GuUSKc0eHXY5oMRS1rt xUIdGo5ao0EfSsR+C1UuUWWuj6CQcP553UnSDt4ZDHo7+VXmj0eLalkVQrng4uIK 8mOfAKcEGcqmOJFQfTt0IWp2D+mAviiTZyb6UmCa/qCcuzED3Ocdly3u+TI1nAjT bDjrhSiOcB9ITw+4aSxDA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1667404044; x= 1667411244; bh=4IBWSvy4lxlXHSuY+tjexTOB1Q3vxjtYOhhT6BxakwU=; b=X kANHIVB8B+IPX2F9e40YoKGEbx9l/6cSWjJM+i0ihlNXjkWfW/ghzACe5q2Y0ne9 /MbXS4qt0Zy2xKyOCOeybnip/A8Rf+qDGGQeXkveEfTWz+s7gtapcDx8VnBo6Ku6 yzc+xlMyQTI9Y5NILCVrJEx8zdgIWuvhTyXvBvOgw9cA74/XV1B3YNXaP0h4DUr9 yzefMYdouU2kOIrj+IHJgLeNp+dPkR9Yix+86lWKCO9EZPNZcBqN8D0Jz5PJZRmw Fmrz9uRHlzzhK0dliWAKfgmFrhw0fipO3CrBIvsu8e2vZM9O6N7qosGVwHHojkYm 9/fTzUuCpwmX4vfv1yCsg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrudejgdektdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnheptdejieeifeehtdffgfdvleetueeffeehueejgfeuteeftddtieek gfekudehtdfgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 2 Nov 2022 11:47:15 -0400 (EDT) From: Thomas Monjalon To: Rahul Bhansali Cc: Stephen Hemminger , dev@dpdk.org, Bruce Richardson , ferruh.yigit@xilinx.com, ajit.khaparde@broadcom.com, aboyer@pensando.io, andrew.rybchenko@oktetlabs.ru, beilei.xing@intel.com, chas3@att.com, chenbo.xia@intel.com, ciara.loftus@intel.com, dsinghrawat@marvell.com, ed.czeck@atomicrules.com, evgenys@amazon.com, grive@u256.net, g.singh@nxp.com, zhouguoyang@huawei.com, haiyue.wang@intel.com, hkalra@marvell.com, heinrich.kuhn@corigine.com, hemant.agrawal@nxp.com, hyonkim@cisco.com, igorch@amazon.com, irusskikh@marvell.com, jgrajcia@cisco.com, jasvinder.singh@intel.com, jianwang@trustnetic.com, jiawenwu@trustnetic.com, jingjing.wu@intel.com, johndale@cisco.com, john.miller@atomicrules.com, linville@tuxdriver.com, keith.wiles@intel.com, kirankumark@marvell.com, oulijun@huawei.com, lironh@marvell.com, longli@microsoft.com, mw@semihalf.com, spinler@cesnet.cz, matan@nvidia.com, matt.peters@windriver.com, maxime.coquelin@redhat.com, mk@semihalf.com, humin29@huawei.com, pnalla@marvell.com, ndabilpuram@marvell.com, qiming.yang@intel.com, qi.z.zhang@intel.com, radhac@marvell.com, rahul.lakkireddy@chelsio.com, rmody@marvell.com, rosen.xu@intel.com, sachin.saxena@oss.nxp.com, skoteshwar@marvell.com, shshaikh@marvell.com, shaibran@amazon.com, shepard.siegel@atomicrules.com, asomalap@amd.com, somnath.kotur@broadcom.com, sthemmin@microsoft.com, steven.webster@windriver.com, skori@marvell.com, mtetsuyah@gmail.com, vburru@marvell.com, viacheslavo@nvidia.com, xiao.w.wang@intel.com, cloud.wangxiaoyun@huawei.com, yisen.zhuang@huawei.com, yongwang@vmware.com, xuanziyang2@huawei.com, hemant.agrawal@nxp.com Subject: Re: [PATCH] examples/l2fwd: add check of Rx packets count Date: Wed, 02 Nov 2022 16:47:14 +0100 Message-ID: <1771490.Zkmt1EvEu4@thomas> In-Reply-To: <28689c21-ee04-866f-a117-be0a073239b8@oss.nxp.com> References: <20220525091327.4006824-1-rbhansali@marvell.com> <20220720103254.0a7a0c4e@hermes.local> <28689c21-ee04-866f-a117-be0a073239b8@oss.nxp.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 02/11/2022 15:09, Hemant Agrawal: > On 20-Jul-22 11:02 PM, Stephen Hemminger wrote: > > On Wed, 25 May 2022 14:43:27 +0530 > > Rahul Bhansali wrote: > > > >> An additional check is added to avoid extra processing if > >> receive packets are 0. > >> > >> Performance impact: with Marvell OCTEON TX2 platform, observed an > >> improvement by ~14%. > >> > >> Signed-off-by: Rahul Bhansali > > This makes sense. Could drop the unlikely() since in general unlikely > > should be reserved for error cases. But doubt it matters at all. > > > > Did a quick check the other examples do similar thing already. > > > > Acked-by: Stephen Hemminger > Acked-by: Hemant Agrawal Applied, thanks.