From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f50.google.com (mail-wm0-f50.google.com [74.125.82.50]) by dpdk.org (Postfix) with ESMTP id 20A602B98 for ; Wed, 26 Oct 2016 23:43:20 +0200 (CEST) Received: by mail-wm0-f50.google.com with SMTP id e69so59821684wmg.0 for ; Wed, 26 Oct 2016 14:43:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=EBDvaoZ66Ge7jvpp822W+KsXDdo0qZz3JenmYwyrcVU=; b=rOmdYT9B4gpU1N6MMKNo6ONrLOEt2WfBacbsf1OGb8Cmy5i10Q0oBJThPHcnzp/4co gpKpoAV0E4kizzg0Ypi5jZdCFYV5HAdveqWzvPrEmpBkp81YI3N6NF/feen1hfFCGIgo 7mAqn9qIjXBQfDekrsQQA2jgtyLIJihriHb1bkXMBV4WGoUeKUgHiJHJmYwCyXeu6Nf3 8SvO27bV9I/FF/gVHdmUWW+LM2XTkWPc5Yw66za2CfBaH4F9c3aGcTFxwiu8pO355pP7 BPxEuOftSLNmsVi0GnLkOaiYxpnHLz8CE0Gb85y8PEICbAaR5d9VWV4hbL9IOIy7ddZg KjaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=EBDvaoZ66Ge7jvpp822W+KsXDdo0qZz3JenmYwyrcVU=; b=a1TE3xJ4q62leorbTw0wNmAzEiVDaSKIsaFBwC69nMClit9mk2OywfLrhnNNs2/9Qu 0ZMsH+btQnb4PXdrD0a3Bw3mNtP2pc4zeQSaXRkLjV04phUK1RXkl5kC4PfYzvTR75v0 W9KTjy8HiQpjx2Z8z54szMe3T/4Fvo59bfmgbiu+ILp2w6OTeVrBVQnUi+nBNEBg5ILZ NiDWUQVCLvAKHEsrNgZu+KIsIpOVjZXcEfJ7QvZFlGUApbT5nGaQgyFH0euYe9T09VrL Y412oQrf6KOL1poq3Hy6qD4YfmcVFiDtZS0eWlQhA8dx/cjuCLVlmUTSdBOd6S75ul83 G00Q== X-Gm-Message-State: ABUngvd2u86RGbRiAISYKWJWMfHOvtiDD87+pK6dqDVzKYAkgPpG4Y9Dg1F1gOuyVqo+XUMj X-Received: by 10.194.202.195 with SMTP id kk3mr3800869wjc.37.1477518199882; Wed, 26 Oct 2016 14:43:19 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id 186sm11750047wmy.13.2016.10.26.14.43.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 26 Oct 2016 14:43:19 -0700 (PDT) From: Thomas Monjalon To: Harish Patil Date: Wed, 26 Oct 2016 23:43:18 +0200 Message-ID: <1772382.AymLqBrjhc@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: References: <1476850306-2141-1-git-send-email-rasesh.mody@qlogic.com> <4491648.SeJM0cAZEU@xps13> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Cc: dev@dpdk.org, Dept-Eng DPDK Dev , ferruh.yigit@intel.com Subject: Re: [dpdk-dev] [PATCH v4 18/32] net/qede: add missing 100G link speed capability X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Oct 2016 21:43:20 -0000 2016-10-26 21:28, Harish Patil: >=20 > >2016-10-18 21:11, Rasesh Mody: > >> From: Harish Patil > >>=20 > >> This patch fixes the missing 100G link speed advertisement > >> when the 100G support was initially added. > >>=20 > >> Fixes: 2af14ca79c0a ("net/qede: support 100G") > >>=20 > >> Signed-off-by: Harish Patil > >[...] > >> [Features] > >> +Speed capabilities =3D Y > > > >This feature should be checked only when it is fully implemented, > >i.e. when you return the real capabilities of the device. > > > >> --- a/drivers/net/qede/qede_ethdev.c > >> +++ b/drivers/net/qede/qede_ethdev.c > >> @@ -599,7 +599,8 @@ qede_dev_info_get(struct rte_eth_dev *eth_dev,= > >> =09=09=09=09 DEV_TX_OFFLOAD_UDP_CKSUM | > >> =09=09=09=09 DEV_TX_OFFLOAD_TCP_CKSUM); > >> =20 > >> -=09dev_info->speed_capa =3D ETH_LINK_SPEED_25G | ETH_LINK_SPEED_4= 0G; > >> +=09dev_info->speed_capa =3D ETH_LINK_SPEED_25G | ETH_LINK_SPEED_4= 0G | > >> +=09=09=09 ETH_LINK_SPEED_100G; > >> } > > > >It is only faking the capabilities at driver-level. > >You should check if the underlying device is able to achieve 100G > >before advertising this flag to the application. > > > >I suggest to update this patch to remove the doc update. > >The contract is to fill it only when the code is fixed. > >By the way, we must call every other drivers to properly implement > >this feature. > > >=20 > Hi Thomas, > Its not really a faking. The same driver supports all three link spee= ds. > The required support for 100G was already present in the 16.07 inbox > driver. > We just had missed out advertising 100G link speed via > dev_info->speed_capa. > Hence it is - Fixes: 2af14ca79c0a ("net/qede: support 100G=E2=80=9D).= > Hope it is okay. Yes the code is okay. But it is not complete. Please tell me you understand that you must fill speed_capa depending of the device capabilities. Then you will be able to fill "Speed capabilities" box in the doc.