* [dpdk-dev] [PATCH] mk: fix compilation for icc version 16
@ 2015-11-20 14:34 Declan Doherty
2015-11-20 15:34 ` Olivier MATZ
0 siblings, 1 reply; 3+ messages in thread
From: Declan Doherty @ 2015-11-20 14:34 UTC (permalink / raw)
To: dev
This patch changes the ICC conditional check to disable
-no-inline-max-size and -no-inline-max-total-size to be
for all versions of icc greater than 14 and not just for version 15.
Signed-off-by: Declan Doherty <declan.doherty@intel.com>
---
mk/toolchain/icc/rte.vars.mk | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/mk/toolchain/icc/rte.vars.mk b/mk/toolchain/icc/rte.vars.mk
index e39d710..9b6b34b 100644
--- a/mk/toolchain/icc/rte.vars.mk
+++ b/mk/toolchain/icc/rte.vars.mk
@@ -74,8 +74,8 @@ WERROR_FLAGS += -diag-disable 13368 -diag-disable 15527
# process cpu flags
include $(RTE_SDK)/mk/toolchain/$(RTE_TOOLCHAIN)/rte.toolchain-compat.mk
-# disable max-inline params boundaries for ICC 15 compiler
-ifeq ($(shell test $(ICC_MAJOR_VERSION) -eq 15 && echo 1), 1)
+# disable max-inline params boundaries for ICC compiler for version 15 and greater
+ifeq ($(shell test $(ICC_MAJOR_VERSION) -ge 14 && echo 1), 1)
TOOLCHAIN_CFLAGS += -no-inline-max-size -no-inline-max-total-size
endif
--
2.5.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] mk: fix compilation for icc version 16
2015-11-20 14:34 [dpdk-dev] [PATCH] mk: fix compilation for icc version 16 Declan Doherty
@ 2015-11-20 15:34 ` Olivier MATZ
2015-11-20 16:08 ` Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: Olivier MATZ @ 2015-11-20 15:34 UTC (permalink / raw)
To: Declan Doherty, dev
Hi,
On 11/20/2015 03:34 PM, Declan Doherty wrote:
> This patch changes the ICC conditional check to disable
> -no-inline-max-size and -no-inline-max-total-size to be
> for all versions of icc greater than 14 and not just for version 15.
>
> Signed-off-by: Declan Doherty <declan.doherty@intel.com>
> ---
> mk/toolchain/icc/rte.vars.mk | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/mk/toolchain/icc/rte.vars.mk b/mk/toolchain/icc/rte.vars.mk
> index e39d710..9b6b34b 100644
> --- a/mk/toolchain/icc/rte.vars.mk
> +++ b/mk/toolchain/icc/rte.vars.mk
> @@ -74,8 +74,8 @@ WERROR_FLAGS += -diag-disable 13368 -diag-disable 15527
>
> # process cpu flags
> include $(RTE_SDK)/mk/toolchain/$(RTE_TOOLCHAIN)/rte.toolchain-compat.mk
> -# disable max-inline params boundaries for ICC 15 compiler
> -ifeq ($(shell test $(ICC_MAJOR_VERSION) -eq 15 && echo 1), 1)
> +# disable max-inline params boundaries for ICC compiler for version 15 and greater
> +ifeq ($(shell test $(ICC_MAJOR_VERSION) -ge 14 && echo 1), 1)
> TOOLCHAIN_CFLAGS += -no-inline-max-size -no-inline-max-total-size
> endif
>
>
Acked-by: Olivier Matz <olivier.matz@6wind.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] mk: fix compilation for icc version 16
2015-11-20 15:34 ` Olivier MATZ
@ 2015-11-20 16:08 ` Thomas Monjalon
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2015-11-20 16:08 UTC (permalink / raw)
To: Declan Doherty; +Cc: dev
2015-11-20 16:34, Olivier MATZ:
> On 11/20/2015 03:34 PM, Declan Doherty wrote:
> > This patch changes the ICC conditional check to disable
> > -no-inline-max-size and -no-inline-max-total-size to be
> > for all versions of icc greater than 14 and not just for version 15.
> >
> > Signed-off-by: Declan Doherty <declan.doherty@intel.com>
>
> Acked-by: Olivier Matz <olivier.matz@6wind.com>
Applied, thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-11-20 16:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-11-20 14:34 [dpdk-dev] [PATCH] mk: fix compilation for icc version 16 Declan Doherty
2015-11-20 15:34 ` Olivier MATZ
2015-11-20 16:08 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).