From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f179.google.com (mail-wi0-f179.google.com [209.85.212.179]) by dpdk.org (Postfix) with ESMTP id 73E2D9A97 for ; Wed, 18 Mar 2015 17:03:20 +0100 (CET) Received: by wibg7 with SMTP id g7so94274952wib.1 for ; Wed, 18 Mar 2015 09:03:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=qvTJaFyLht4a+IeY7a+ub72jIZ5IRK0eWk0VICgY29I=; b=XiZ00QzQu7W0izcnc/nQHHIkvM8V8dTC0r0YhO/xwnjugKCAJWRyZIm6Im3/0XPXOX ZsNfX6bsF7AMNW1hi2H1WlyGrllqaIltxSnhucg2NFEpdWaUsNkoCpN/mdLKBrLysfw+ 61zm21HHhG2P/We5NR6EHGoGsnZZGOnJqHYVqagYJPz3WwQD5/Quf3p0/24/jQ2wqRw+ 8SHyK2wIztJ21I/a0EO2uZS8PFLW/AyY5GV/z0nlqRe37Bv6/Ijx9QkChV7e4xJH5lpT EFBAxL+9uUpiAruuTZKe8HnIXS2UdbJK6MzEkzYR4tXl9iQKwfpJ6PuLyl4VT4pht+3I hNqQ== X-Gm-Message-State: ALoCoQnzdwpRG9aPO/OgmyZzuaf1OiHpDWcMAhECpXe9I/Sb9C4UJBPyqQBBimpfi5YswqhvA2P/ X-Received: by 10.180.189.35 with SMTP id gf3mr8045629wic.5.1426694600323; Wed, 18 Mar 2015 09:03:20 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id i10sm25054638wja.40.2015.03.18.09.03.19 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 18 Mar 2015 09:03:19 -0700 (PDT) From: Thomas Monjalon To: "Ananyev, Konstantin" Date: Wed, 18 Mar 2015 17:02:44 +0100 Message-ID: <1772941.ZquV42oMuH@xps13> Organization: 6WIND User-Agent: KMail/4.14.4 (Linux/3.18.4-1-ARCH; KDE/4.14.4; x86_64; ; ) In-Reply-To: <2601191342CEEE43887BDE71AB977258213F71C4@irsmsx105.ger.corp.intel.com> References: <1426676283-7779-1-git-send-email-konstantin.ananyev@intel.com> <12406601.aPV9NrFM6W@xps13> <2601191342CEEE43887BDE71AB977258213F71C4@irsmsx105.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] EAL: move rte_common_vect.h into arch/x86 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Mar 2015 16:03:20 -0000 2015-03-18 15:24, Ananyev, Konstantin: > > Hi Thomas, > > > -----Original Message----- > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > Sent: Wednesday, March 18, 2015 1:14 PM > > To: Ananyev, Konstantin > > Cc: dev@dpdk.org > > Subject: Re: [dpdk-dev] [PATCH] EAL: move rte_common_vect.h into arch/x86 > > > > Hi Konstantin, > > > > 2015-03-18 10:58, Konstantin Ananyev: > > > lib/librte_eal/common/Makefile | 1 - > > > .../common/include/arch/x86/rte_common_vect.h | 128 +++++++++++++++++++++ > > > lib/librte_eal/common/include/rte_common_vect.h | 128 --------------------- > > > > I think rte_vect.h is a better name as common is not anymore relevant. > > I don't mind, but it means more changes - all files which include it, would need to be changed. I think file naming deserves it. > > Should we add an empty file in ppc_64 directory? > > I thought about that too, but it seems not necessary. > It is included by: > lib/librte_lpm/rte_lpm.h > lib/librte_eal/common/include/arch/x86/rte_memcpy.h > lib/librte_acl/rte_acl_osdep.h > > As I understand, neither LPM, neither ACL are supported on PPC right now. > Again, if we'll provide an empty one for PPC, it wouldn't help to compile LPM/ACL on PPC anyway, > as both use SSE instrincts inside their code. Yes, it was an open question. It's probably better to create the PPC file when really needed.