From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by dpdk.org (Postfix) with ESMTP id 60CA491 for ; Mon, 12 Nov 2018 01:23:36 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id D4902847; Sun, 11 Nov 2018 19:23:34 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Sun, 11 Nov 2018 19:23:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=H7z8QKY1VFCAOb1zcP7PaQS5cgiPRqnl1Y/78L6e2BQ=; b=aMIhLgS046jx 1/kGYBWXabuZ/jNXfXlk7ffS30V95pQlC4C3DlP9VDIuUPb+gyB7PDk4jhkOk0OS nxPAQb7bvw5LSOBE2q3FgLfVs7FwAnVxAwSaA3TdDI5/aYfi2HGlKbe/bq4tvvpT Okd5kgcDf3u0VfOpqpNGcTzEvVQxoJQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=H7z8QKY1VFCAOb1zcP7PaQS5cgiPRqnl1Y/78L6e2 BQ=; b=k6JkBI4KN/oVkrUqa2Vz/ikUex0QqkXIpQC1Wp5I0UKYwCWmGm39vP996 vG+7rkExPSnvt1162ukPWGG5CslljfVMUVAXvXAzp3g5LXTq95IiP3VfH8z8Z7DU VO5R/O89ECxChLs6OO9kCXcgspC7mIRBvBZsRSCbLBlx17aGzbCf1sq2UXeOk/3L kyRjCylF4d1k+ujBu91IVyvYdx6CT/mv/+bSrEOzUhIQBn3d2AVebYTMoDcNWlgL gTx9+S53StN6mpZLLBFnEU8ahc4EJULz5ag089IkKnD/KmYz84ZDreVLLpPRDJpn dLzwagTjOewxVzG5nK8BFKLtZwBZA== X-ME-Sender: X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 739B8102E4; Sun, 11 Nov 2018 19:23:32 -0500 (EST) From: Thomas Monjalon To: Kevin Laatz Cc: dev@dpdk.org, Ferruh Yigit , harry.van.haaren@intel.com, gaetan.rivet@6wind.com, mattias.ronnblom@ericsson.com, bruce.richardson@intel.com, radu.nicolau@intel.com, ciara.power@intel.com, brian.archbold@intel.com Date: Mon, 12 Nov 2018 01:23:31 +0100 Message-ID: <1773184.RcDog45q3e@xps> In-Reply-To: <438ce75d-7bf6-1845-2303-d3151e0a71bf@intel.com> References: <20181107181018.80224-1-kevin.laatz@intel.com> <438ce75d-7bf6-1845-2303-d3151e0a71bf@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] telemetry: fix shared build for make X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Nov 2018 00:23:36 -0000 09/11/2018 23:19, Ferruh Yigit: > On 11/7/2018 6:10 PM, Kevin Laatz wrote: > > Currently, telemetry is not working for shared builds in make. > > > > The --as-needed flag is preventing telemetry from being linked as there are > > no direct API calls from the app to telemetry. This is causing the > > --telemetry option to not be recognized by EAL. > > Telemetry registers it's EAL option using the RTE_INIT constructor. Since > > EAL's option parsing is done before the plugins init, the --telemetry > > option isn't registered at the time of parsing, and as a result, the > > --telemetry option is not being recognized. > > > > This patch fixes this issue by explicitly linking telemetry to the > > application by setting the "--no-as-needed" flag for the library in > > mk/rte.app.mk. > > > > Fixes: 8877ac688b52 ("telemetry: introduce infrastructure") > > > > Reported-by: Yanjie Xu > > Signed-off-by: Kevin Laatz > > Reviewed-by: Ferruh Yigit Applied, thanks