From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0B111A034F; Wed, 6 May 2020 15:17:47 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A20DA1D9AF; Wed, 6 May 2020 15:17:46 +0200 (CEST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 532C71D9AB for <dev@dpdk.org>; Wed, 6 May 2020 15:17:45 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id E94B15C00EF; Wed, 6 May 2020 09:17:44 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Wed, 06 May 2020 09:17:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= egUsck60ShiHalU0Xdgdwie8eA4fffUG/m8GR5v0ntM=; b=rdsfVUbDq9vLo+U3 xZXbGJCQDqOtDTp5Nzf7jznHB3MLR8ioU4rULGUdVBVOB89fxxQfxWHmvGEujYQC 7u9Zj/zV+GrlJnXJocI8O3yFmgrb7pX36UKCEDqceedAYXNJHS9GfEed3OqtQ/DM nnEvtv8ZoAknuP5H+dVDQdg6zgHSQDoxMieWO/9BQnRuxhA9d6hG83kGfzhkRUac /oKT1PM7GZiqjRA6x7jd//G2ZZTd/8Np3DfXiqKUetkV83stckp3SLT6BNTcMe0t 4OlcMopm2WRFaBm6Doc2n1M2fuXyzKg9EKgbOf+42H/yvNdgDDGpIDW7WWDH43GE cxJngg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=egUsck60ShiHalU0Xdgdwie8eA4fffUG/m8GR5v0n tM=; b=pPp8iwh+jgyQ7kDMpu1IFGetGE6OXynh1Kic2SmgRalHCZShhthSmamwC Y+57Isl3FQpQn4CCeZjeQSC7tzph2xfB0YiInbw7u0Fq42isCVe2J2EfiE1c4fy+ I7A5QJEl/8glkAvzvWMXHzdYJH1RLVfFhiWVe3p/rclZNdY4309sUcSA5RN2cekM SfRTWVEsJrwSWDGd4pBIyhpXj6VJJx3GyvMAM3wtvzfQ3OhDumosBve3vmyVYoV/ T6RRe9c6dC92Tng1BnD8ASFDAPGwN576isotPm9QHwwfSPbEKmXsNLgQ/z0uv3KB d4pCQogkDTWZ8LgPF0hJkwqNdNeZQ== X-ME-Sender: <xms:-LiyXm7pVPYfhpX1L4DgXXyee1Z7vCa8m5sW7kcHvi7raJ9tZB58Yw> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrjeekgdeitdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: <xmx:-LiyXttFaJq2jTqv648EzWSArNX7qTqiulgPEjf-pnDLciyz820I7Q> <xmx:-LiyXv61TWrq_CD6p7Z6A08vlAT2KhclvnzD4vM2mWv0kWI_qfESeg> <xmx:-LiyXgX_Vm1LEiRrYqr_t3C0ZwfLXxVKfjOm7L4NKwjLMPAKDtRo1Q> <xmx:-LiyXj-tj4P3M1KXdM4jvg3TW_q7-NA3cfEozEmOQ27FsEaDcOoBKg> Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 961653280066; Wed, 6 May 2020 09:17:43 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: Ferruh Yigit <ferruh.yigit@intel.com> Cc: Asaf Penso <asafp@mellanox.com>, arybchenko@solarflare.com, viacheslavo@mellanox.com, matan@mellanox.com, dev@dpdk.org Date: Wed, 06 May 2020 15:17:42 +0200 Message-ID: <1774318.eGJsNajkDb@thomas> In-Reply-To: <881eb141-7120-3eeb-3d9e-df9072e3b892@intel.com> References: <1588762695-2489-1-git-send-email-asafp@mellanox.com> <1588767728-5722-1-git-send-email-asafp@mellanox.com> <881eb141-7120-3eeb-3d9e-df9072e3b892@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3] net/mlx5: add 200G link speed X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> 06/05/2020 14:59, Ferruh Yigit: > On 5/6/2020 1:22 PM, Asaf Penso wrote: > > There is no way to report back a link speed of 200Gbps. > > > > Adding 200G link speed. > > > > Signed-off-by: Asaf Penso <asafp@mellanox.com> > > --- > > v2 - reword commit log and remove 400G > > > > v3 - rebase and fix checkpatch warning > > --- > > app/test-pmd/cmdline.c | 12 +++++++----- > > doc/guides/rel_notes/release_20_05.rst | 2 ++ > > doc/guides/testpmd_app_ug/testpmd_funcs.rst | 2 +- > > drivers/net/mlx5/mlx5_ethdev.c | 22 +++++++++++++++++++++- > > lib/librte_ethdev/rte_ethdev.c | 2 ++ > > lib/librte_ethdev/rte_ethdev.h | 2 ++ > > 6 files changed, 35 insertions(+), 7 deletions(-) > > Hi Asaf, > > Patch looks good, but it updates ethdev & testpmd to have 200G defines and mlx5 > to use it, so net/mlx5 prefix not really fits to the patch, can you separate > mlx5 changes into another patch? I think I was the one advising to squash all. The reason is that the changes in testpmd and ethdev are simple and mechanical. The real change is in mlx5 in my opinion, but I'm fine with splitting as well.