From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f54.google.com (mail-wm0-f54.google.com [74.125.82.54]) by dpdk.org (Postfix) with ESMTP id CCD9A2142 for ; Thu, 30 Jun 2016 14:44:35 +0200 (CEST) Received: by mail-wm0-f54.google.com with SMTP id a66so116926302wme.0 for ; Thu, 30 Jun 2016 05:44:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=5YnEqqoJ162MjSEmhDEHmJDha1gI7Be8L+kc/9f0MfI=; b=ljdy6JYnwnVxB6kotwMNIBZfC/INkTVKPSR8faxNlVR/jE0hm94kRglv9MiLKAC7of SPkolxYuZgVvhbr2YxsHNIw00RdWOhKQV6fTumTTEL2TPy6aw9ZeHulTJEMmphlA5m8m eskpuamYAsOxE1uTw82aXf7U9mWs7FHkyDKQNSoS475KEU+UJJNC0i9OmKsC2lwEMMmQ 6IuQttRP8/KdI70zwLomcbOZzr9C0XUxWIMvWes9s6Oy2ylFPk/l/Ja/+z+R9fb0HF/f HwPfNIDmZ+kBHJqPGxMsSmIa+A4fKaig5KyIyv265snG3bMXsDWczy+j4ai/2wYQpE/n rc4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=5YnEqqoJ162MjSEmhDEHmJDha1gI7Be8L+kc/9f0MfI=; b=GLWizuQHnfqDJSI5E+10wu/mqlCTDGIWj2UfjCfPBkUlS1r+2vFGpeqDfYnENjfXoZ hxVYCQ6dtksBqucPKqPwsYVyuHUoaL2THJt55Kr5rfYSkH+w0cQtL7GaGmP/QiqUJ+XC up0cOh6VgqLCzxzlJo5P1ydWLax4gLU8hF99EuBq8yEXncrxUd+Bxx2khKGbmijkGERY V/QCfrRK29evZuTos0SS/TdQIrwppti+ySchuyGU1yT3X0BgSucyUmsBXnAWvQAbOU0l OBK6fXKL644Jkdh68B0k4eaUGZ+ZZDVYsLlgPC24OMFKjEahuwMuFHL7SitZDj/L3GMn U2gA== X-Gm-Message-State: ALyK8tIh9Kh/AY2oNpFha7mucsByeGdz3K6Y2nvBKYwrK15R5XKbttzKccF4tqIt3VvJPFCP X-Received: by 10.194.200.103 with SMTP id jr7mr13661349wjc.105.1467290675616; Thu, 30 Jun 2016 05:44:35 -0700 (PDT) Received: from xps13.localnet (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by smtp.gmail.com with ESMTPSA id t190sm3474378wmt.24.2016.06.30.05.44.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 30 Jun 2016 05:44:34 -0700 (PDT) From: Thomas Monjalon To: Sergio Gonzalez Monroy Cc: dev@dpdk.org Date: Thu, 30 Jun 2016 14:44:30 +0200 Message-ID: <1776198.xo6Bm4C5fO@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: References: <1467285021-103920-1-git-send-email-sergio.gonzalez.monroy@intel.com> <5547616.scaE5dMnT7@xps13> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] mk: fix acl library static linking X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Jun 2016 12:44:36 -0000 2016-06-30 13:04, Sergio Gonzalez Monroy: > On 30/06/2016 12:38, Thomas Monjalon wrote: > > Does it need to be commented in rte.app.mk? > > The other libs are in whole-archive to support dlopen of drivers. > > But the problem here is not because of a driver use. > > There seem to be a bunch of libraries under --whole-archive scope that > are not > PMDs, ie. cfgfile, cmdline... > > What is the criteria? The criteria is a bit vague. We must try to include only libs which can be used by a driver. cmdline should probably not be there. Does it make sense to use cfgfile in a driver? maybe yes.