From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 280C9A0C47; Tue, 12 Oct 2021 18:59:36 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 18C57410E5; Tue, 12 Oct 2021 18:59:34 +0200 (CEST) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by mails.dpdk.org (Postfix) with ESMTP id E8EA2410E0 for <dev@dpdk.org>; Tue, 12 Oct 2021 18:59:31 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 5C73A5C019E; Tue, 12 Oct 2021 12:59:31 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Tue, 12 Oct 2021 12:59:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= tFNNjTHT3y5YhrXvvSB7Z8yUE6azSmGhQgfvoFilFa4=; b=NXW7cmNP3YAsNHrD vNA8Ny0lGQXi0c0KKfSG79MkVzfp3pMQNmjd3sOPvS36kxKv6dGXsJP4n9gYzpla Zm+uTWxGGjT0OIvP9wBxOzuniqVk/3K464uiurpU8MtIS/KPBZrSkNkRw/4EV/UW iIHLZ8QOnvSHh300PtJlBI8zhdaeqcBq0FSd4/wTVbPYy7jA/1VknWh8f1bX2hag Vc2V3ylJAyBndFU9B9Xs9JPSsROCRLs5rM5G04jey3vZKiuo6AY9xHAL/5TPuU4Z GI3Wv4Z13RLm8Hy+NXVaRmATCEhdx3mketjMUvm7d/76oZU+eZHQVKXmF7yYJCjg iI0qEg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=tFNNjTHT3y5YhrXvvSB7Z8yUE6azSmGhQgfvoFilF a4=; b=QaT7+lDlCTN5SkDJKWI55eV6cSIlOBCgQJP8K0EAi0OmqdM7a1M1SzAAB dvxQ3NiwAPXtwm+VyEWYWLkg2cG01W/WsGz8WZHjPDUBjegDecRJm98fT2dib+1Z DIOpDakBJvYq2lm05h9Asg8XuNbC7y3vfczYNvahsLoLrBoI1dxqrnmsPMxaLL7m o+otfzl4GzRQ9qP7IbfBP/RJWl8sYyFBHbMQ0D7uBx2UfAoIwJyb3CSHRjcDYGWu C2pXR0XEGxFXIYMZkZ1ERh7xW4RfFceqAxQ6edbQl56YW2BQjXp0lbGlfxwIUuWa uZ20OWcei4OLCInG+2QKBO4D2KAGg== X-ME-Sender: <xms:875lYd6h-U_wkfPpchUy1Pq2Rbf_ab9-VTv2SfByV-pohVSt5XxETg> <xme:875lYa57VVlHuPPzmNu6Ueb3ip_IqtxWqmXGWTN160Ok0DDLw_Crn2tPyQhf4JxMR 44m2TmwAWeQKawxkQ> X-ME-Received: <xmr:875lYUdVTLbDt-yecpUNIOCNmS9Tobghx3x4sV0MG9-ny7-otgsmWuxoI1Vdvg6OUdLXG3entNENTvDsAjfUeDJw-wqe7VbnsPtvjIN-> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrvddtkedguddthecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdej ueeiiedvffegheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: <xmx:875lYWKFdacImX6gKcUyY-8dxppmpzXcZA7B6wxVPTtotg1lj4LDkA> <xmx:875lYRKbexG1WCHokKHFw1E6keq3V3EJdwegIZAup1AIAo7tCdhn2w> <xmx:875lYfzOcZBXKbjgFJMObK0ud92fq-v7uxbmZSqo22U2YUxMYvKU8g> <xmx:875lYfiY5SDEvNLvFn1aUndFeecVaHfiB_iuE3qPCctA7_My7Gc_GQ> Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 12 Oct 2021 12:59:29 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: "Chautru, Nicolas" <nicolas.chautru@intel.com> Cc: "gakhil@marvell.com" <gakhil@marvell.com>, "dev@dpdk.org" <dev@dpdk.org>, "trix@redhat.com" <trix@redhat.com>, "hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>, "Zhang, Mingshan" <mingshan.zhang@intel.com>, "Yigit, Ferruh" <ferruh.yigit@intel.com> Date: Tue, 12 Oct 2021 18:59:27 +0200 Message-ID: <1776453.NkHoZ63Jat@thomas> In-Reply-To: <BY5PR11MB4451838B77A81E729E821FE9F8B69@BY5PR11MB4451.namprd11.prod.outlook.com> References: <1628873485-30596-1-git-send-email-nicolas.chautru@intel.com> <2349964.oiB3URGJAo@thomas> <BY5PR11MB4451838B77A81E729E821FE9F8B69@BY5PR11MB4451.namprd11.prod.outlook.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v1 1/6] bbdev: add capability for CRC16 check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> 12/10/2021 18:36, Chautru, Nicolas: > From: Thomas Monjalon <thomas@monjalon.net> > > 11/10/2021 22:38, Chautru, Nicolas: > > > From: Thomas Monjalon <thomas@monjalon.net> > > > > 13/08/2021 18:51, Nicolas Chautru: > > > > > Adding a missing operation when CRC16 is being used for TB CRC > > > > > check. > > > > > > > > > > Signed-off-by: Nicolas Chautru <nicolas.chautru@intel.com> > > > > > --- > > > > > --- a/doc/guides/rel_notes/release_21_11.rst > > > > > +++ b/doc/guides/rel_notes/release_21_11.rst > > > > > @@ -84,6 +84,7 @@ API Changes > > > > > Also, make sure to start the actual text at the margin. > > > > > > > ======================================================= > > > > > > > > > > +* bbdev: Added capability related to more comprehensive CRC > > options. > > > > > > > > That's not an API change, the enum symbols are the same. > > > > Only enum values are changed so it impacts only ABI. > > > > > > Hi Thomas, > > > How is that not a API change when new additional capability are exposed? > > Ie. new enums defined for new capabilities. > > > > API change is when the app source code has to be updated. > > Thanks. What you are referring to may be strictly API breakage as opposed to generic API change. I would expect an API change could be either backward compatible (extending API but application only has to change if it wants to use the new functionality) vs an actual API breakage (application needs to change regardless even to keep same functionality as before). Yes An API change which does not break is a new feature, so it is referenced at the beginning of the release notes in general. > In case the intent is to use the 2 terms interchangeably (change vs breakage) then I agree that these 2 bbdev changes do not constitute an API breakage (only ABI). > It might be good to capture this more explicitly except if you believe this is obvious (doc describes ABI change, not API change). Regardless for next time I will use that distinction (change == breakage). Yes feel free to send a patch to rename "change" to 'breakage".