From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id E09B8A09FF;
	Mon, 11 Jan 2021 17:05:32 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id C3774140F12;
	Mon, 11 Jan 2021 17:05:32 +0100 (CET)
Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com
 [64.147.123.19])
 by mails.dpdk.org (Postfix) with ESMTP id 439AE140F0D
 for <dev@dpdk.org>; Mon, 11 Jan 2021 17:05:31 +0100 (CET)
Received: from compute2.internal (compute2.nyi.internal [10.202.2.42])
 by mailout.west.internal (Postfix) with ESMTP id 006A52371;
 Mon, 11 Jan 2021 11:05:29 -0500 (EST)
Received: from mailfrontend2 ([10.202.2.163])
 by compute2.internal (MEProxy); Mon, 11 Jan 2021 11:05:30 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding:content-type; s=fm3; bh=
 uJCws0GCF8kTaHUfMKwKBCdfmiggqKgSoP5FWjaHHVU=; b=WFsZI452j8xWscR6
 8mjDje7nuUp2VAW1zZTbtMXIjHofDteeIGFRAeuqG3mXnqv1EeexRHO73WEDHGcH
 bjIAiLeVnsNIFQH7DxftUVdV7+NI6U8+Ss3mAIbBpwQtUpP4M35mOUMOq6H1gYiq
 mScTTauPFMTQWjzcFKHHO8azjltlZ33+rufdxoUxHEQCgk6o03iBAZC/YyNm1wjT
 VDiTDyVH2uY3EpJYJM6VATG0T14ImSKYNz8VKWebzEo0eWuYVpmzG6rRNgG3D+EG
 b7QCuIOWgvfDO8MsNyROFgYDJjnIMNxrOTJD97cFXtdbTX4xlFUfWN9hMPxO9uOM
 g5X5VA==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
 :x-sasl-enc; s=fm1; bh=uJCws0GCF8kTaHUfMKwKBCdfmiggqKgSoP5FWjaHH
 VU=; b=qfxO/LxJDrmKqMwLDDsktzkkS84X6ys9HeQXTbw6WJlaq4CgdDajDtbrj
 8mTxZN0xupynM6ujDK2FvABnHQx+f1v6SKeUiE2HmuFXT5n9hc0xFktmDpetUfuj
 PETLbAeE27mcVEJ8KC0/mMGaMcxR6OE2rCjdzahF4mwYQjmYe8xoESIWMEqacE0z
 Ir21bzbof/Y+foFNwL6mh8W06e8Ogd/akmPx7rP7YRmxxwem2qPun6qGxbick9sf
 5pAea0HLokDsxXTSFxAj7aVquJxFw1yo/vivdogVRPqXp4jkUTOzxNHbSMZq8m5u
 D8ofLNIeaBakRf9O26UOQ/FvPfxpg==
X-ME-Sender: <xms:SXf8X5QV7LSu8_okcgRv3CuY1rwNVZV_GAb4Zhqnq_JHCHwOVBcfBQ>
 <xme:SXf8X8ba7DtULDlJ17cDNgeecUbQk9NLqIgflym3CwmthKiI63FsE12Wcd8XsfgxY
 VWCpdYM3WlWKKyPeQ>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrvdehuddgkeehucetufdoteggodetrfdotf
 fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
 uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
 cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr
 shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg
 ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu
 ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf
 hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl
 ohhnrdhnvght
X-ME-Proxy: <xmx:SXf8X-0BwWRNYIV2c_gdqyA5BeurQi4MIofWlWc9mSj9kEm2xXcO9A>
 <xmx:SXf8X0XI4s760SmwaUAQGnsrXQLldIyaDa9wr3wQk-6eYUUwyHQRtA>
 <xmx:SXf8XwXH4zSWPrhSPVv-258Qm64TUI3JtOvPgH0j941LAVmeqrrbeA>
 <xmx:SXf8X0h98GFUF0imjfQiyfQ1ywfxlqOh26OY7Frjf-gNOMRNR4BrKQ>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id 70467108005C;
 Mon, 11 Jan 2021 11:05:28 -0500 (EST)
From: Thomas Monjalon <thomas@monjalon.net>
To: Liron Himi <lironh@marvell.com>
Cc: "ferruh.yigit@intel.com" <ferruh.yigit@intel.com>,
 "dev@dpdk.org" <dev@dpdk.org>, Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
 Liron Himi <lironh@marvell.com>
Date: Mon, 11 Jan 2021 17:05:27 +0100
Message-ID: <1776515.fif75YaaBN@thomas>
In-Reply-To: <DM5PR18MB2214024EA87391E98A55BBBBC6AB9@DM5PR18MB2214.namprd18.prod.outlook.com>
References: <20201215222319.13816-1-lironh@marvell.com>
 <2489984.pHaSLPtmOr@thomas>
 <DM5PR18MB2214024EA87391E98A55BBBBC6AB9@DM5PR18MB2214.namprd18.prod.outlook.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [EXT] Re: [PATCH v3] meson: update meson build for
 armada drivers
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

11/01/2021 16:29, Liron Himi:
> Hi Thomas,
> 
> When did you take this MUSDK version?
> Is this your head "pkg-config: expose dma-add-size"?

I'm using musdk-SDK-10.3.5.0-PR2 as recommended in the doc.

> If not, this explain the mvneta issue.
> I already noticed that and pushed a fixed to the github.

I see. So it may need a doc update.

> As for the prefix issue,
> The prefix is being set in the 'configure' phase by using the '--prefix' variable. Have you tried that?

No I didn't try that, and I'm using DESTDIR variable when installing.
Whould it be possible to update the prefix with DESTDIR when installing?



> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net> 
> Sent: Monday, 11 January 2021 13:28
> To: Liron Himi <lironh@marvell.com>
> Cc: ferruh.yigit@intel.com; dev@dpdk.org; Jerin Jacob Kollanukkaran <jerinj@marvell.com>
> Subject: [EXT] Re: [dpdk-dev] [PATCH v3] meson: update meson build for armada drivers
> 
> External Email
> 
> ----------------------------------------------------------------------
> 16/12/2020 22:36, lironh@marvell.com:
> > From: Liron Himi <lironh@marvell.com>
> > 
> > With pkg-config support available within musdk library (from 
> > musdk-release-SDK-10.3.5.0-PR2 version), meson option 'lib_musdk_dir' 
> > can be removed.
> > PKG_CONFIG_PATH environment variable should be set appropriately to 
> > use the musdk library.
> 
> Sorry, it does not work.
> 
> First, when installing MUSDK, the .pc file is not updated with the correct prefix path:
> 	make install DESTDIR=$(readlink -f install) In install/mv/lib/pkgconfig/libmusdk.pc:
> 	prefix=/mv
> instead of:
> 	prefix=/musdk_path/install/mv
> 
> Second, after manually fixing the prefix path and compiling DPDK:
> 
> In file included from musdk/install/mv/include/mv_std.h:101,
>                  from musdk/install/mv/include/drivers/mv_neta.h:100,
>                  from dpdk/drivers/net/mvneta/mvneta_ethdev.h:24,
>                  from dpdk/drivers/net/mvneta/mvneta_rxtx.h:10,
>                  from dpdk/drivers/net/mvneta/mvneta_rxtx.c:7:
> musdk/install/mv/include/env/mv_autogen_build_assert.h:43:5: error:
> "MVCONF_DMA_PHYS_ADDR_T_SIZE" is not defined, evaluates to 0 [-Werror=undef]
> musdk/install/mv/include/env/mv_autogen_build_assert.h:44:2: error:
> #error "MVCONF_DMA_PHYS_ADDR_T_SIZE must match size used during musdk_lib compilation."
> 
> The CFLAGS may be incomplete:
> 	Cflags: -I${includedir} -DMVCONF_TYPES_PUBLIC -DMVCONF_DMA_PHYS_ADDR_T_PUBLIC I fixed it by adding:
> 	-DMVCONF_DMA_PHYS_ADDR_T_SIZE=64
> 
> Please could you fix MUSDK quickly?
> 
> I think I will pull next-net as is, but I consider it is broken.
> 
> 
>