From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f51.google.com (mail-wm0-f51.google.com [74.125.82.51]) by dpdk.org (Postfix) with ESMTP id 7535756A1 for ; Fri, 7 Oct 2016 15:51:46 +0200 (CEST) Received: by mail-wm0-f51.google.com with SMTP id i130so40193284wmg.1 for ; Fri, 07 Oct 2016 06:51:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=d+Bygko67PZJzOEoSiVdEzuqAHTdNAWxbeHxiy4535g=; b=F9SDjmQddgp/oFaCSI/NwF9eYy/Guvq+o43wwWGhGpdlT8xyAgZUpZU9gA1T80B4wX iWRJNegAVD+gd+jXnCdpRHI+xhIBh+X8f5iJEB8kLY8mnBqPuPSogF8Tcq2qnMcUHC01 BIlafAG8C5DWAXZBGeIITLzdq2hBiQlmnH7hXbCmeFk8V4pqGnUp0A5KH1oEBdTzYmDg 5MquWiJ5KxVddiAqlFqG+YpSejA9y6zbz+rjuukhyW3WZT8PfS9/2NWxIMzJQKPoQzu2 mu8jEvVMkWJwIBPotwmkYVssNkVKCCCk4oPt22awWpXEt5wLt8hOUemgidYYLB2WSjHL yCcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=d+Bygko67PZJzOEoSiVdEzuqAHTdNAWxbeHxiy4535g=; b=FDkS3oxkfBUWuYM+SNN1ORYQ9hsoT9mqWhgOqcUjyxXsKvzxz3nclU3WrWZG5xHFh+ t7Pb6hewOF4m6irSexC5E1z4ChQ9yrbNOV4NtHUgSolEoA+JEsdowD2Z2/NcpJQsArRD s53SsKhxWd0aqRpjA+0WJYa5w64MsiU9hHW5YAchl1eVeWBdoH6GYf1uJ1wAz2g34qaK s3lVD3zqI/H+XStjDUED6N28HNVHuRz8sNS7bSSXuf3mPdnxCV+TJ1mOHK55yHvyWNPK fONBWdkh0kW6RPmH2gh+6GwvUX4d+9xcF24ju0kgps39xMhO0BeBzFj7HtsK+nufEvM0 m5EA== X-Gm-Message-State: AA6/9RnMB/wJzWxfwcPxgA3Fs5bWlw5OAPOqAu86lNJ7+ZDIaNVrC8eQlsgFxSJEJKZjqvn8 X-Received: by 10.194.170.163 with SMTP id an3mr17340373wjc.73.1475848306059; Fri, 07 Oct 2016 06:51:46 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id l3sm19831961wjp.17.2016.10.07.06.51.45 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 07 Oct 2016 06:51:45 -0700 (PDT) From: Thomas Monjalon To: Shreyansh Jain Cc: david.marchand@6wind.com, dev@dpdk.org Date: Fri, 07 Oct 2016 15:51:44 +0200 Message-ID: <1776769.u7sKE3cfDQ@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: References: <1475847187-28967-1-git-send-email-shreyansh.jain@nxp.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 1/3] eal/drivers: prefix driver REGISTER macros with EAL X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Oct 2016 13:51:46 -0000 2016-10-07 19:11, Shreyansh Jain: > --- a/mk/internal/rte.compile-pre.mk > +++ b/mk/internal/rte.compile-pre.mk > @@ -87,7 +87,7 @@ endif > PMDINFO_GEN = $(RTE_SDK_BIN)/app/dpdk-pmdinfogen $@ $@.pmd.c > PMDINFO_CC = $(CC) $(CPPFLAGS) $(CFLAGS) -c -o $@.pmd.o $@.pmd.c > PMDINFO_LD = $(CROSS)ld $(LDFLAGS) -r -o $@.o $@.pmd.o $@ > -PMDINFO_TO_O = if grep -q 'DRIVER_REGISTER_.*(.*)' $<; then \ > +PMDINFO_TO_O = if grep 'EAL_REGISTER_.*(.*)' $<; then \ > echo "$(if $V,$(PMDINFO_GEN), PMDINFO $@.pmd.c)" && \ > $(PMDINFO_GEN) && \ > echo "$(if $V,$(PMDINFO_CC), CC $@.pmd.o)" && \ > > --->8--- > CC eal_pci_vfio.o > PMDINFO eal_pci_vfio.o.pmd.c > /bin/sh: 1: > /home/shreyansh/build/DPDK/02_dpdk/x86_64-native-linuxapp-gcc/app/dpdk-pmdinfogen: > not found > /home/shreyansh/build/DPDK/02_dpdk/mk/internal/rte.compile-pre.mk:138: > recipe for target 'eal_pci_vfio.o' failed > --->8--- > > I don't think PMDINFO should be running on eal_pci_vfio file. Isn't it? Every files are scanned for the pattern. > Is it because EAL_REGISTER_* is matching EAL_REGISTER_TAILQ like macro > as well? Probably. That's another argument in favor of good prefixes. I think you should use RTE_DRIVER_REGISTER_ or better, RTE_PMD_REGISTER_ > > I am not very well versed with how PMDINFO is linking with the build > system so any hints/insight into this would be really helpful. > > One I get more clarity on this, I will push a new version of this patch. Thanks