From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f51.google.com (mail-wg0-f51.google.com [74.125.82.51]) by dpdk.org (Postfix) with ESMTP id 13D525686 for ; Thu, 15 Jan 2015 14:40:36 +0100 (CET) Received: by mail-wg0-f51.google.com with SMTP id x12so14923639wgg.10 for ; Thu, 15 Jan 2015 05:40:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=ssnwDy/QXRsVZzk27EpCPKO5GcMjlmhB61LQeaVK+KU=; b=LLJO6vuRcu1HGGeCqaLQ+5ljsiCY5VK8ziXwet2AQOoNDamimIyTKtDpFMSWUE2cWo gS5CRt1/EcQq15FV6kgM+BD/QGigdD7ITIqvNMR8kWTHcDq0FbH90rF3NsBiWQWaemNI Uj6Gs9sAEPLy7/DrRjyZMkIrZoKSYLyHKDT7w+rPfQ5zGgaDIQoTS8oDtnJG93UkeyB3 Lbz2FzFrzJ4bvCiDuBNUp41rMQ+69H1IlVqzB+hQ257eCKvDq80UW9wmqWx0BaKuiiTB tx+PI5auTiJi7Jc6W6lI9N/9d+AM7q9v03OphfubKaGDPMLpU98kwPm7gxsqdohOhGJD bafw== X-Gm-Message-State: ALoCoQkLWYE+tn0EEYxRT5fs5BlIN0HVJIBVpmDtQaRYfvbqJ5IXjRX/hPzD36dNqf7sZlrA/UpQ X-Received: by 10.180.211.34 with SMTP id mz2mr18908199wic.56.1421329235586; Thu, 15 Jan 2015 05:40:35 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id x2sm2150745wjx.9.2015.01.15.05.40.34 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 15 Jan 2015 05:40:34 -0800 (PST) From: Thomas Monjalon To: Declan Doherty Date: Thu, 15 Jan 2015 14:40:12 +0100 Message-ID: <1777245.1puKfUUkev@xps13> Organization: 6WIND User-Agent: KMail/4.14.3 (Linux/3.17.6-1-ARCH; KDE/4.14.3; x86_64; ; ) In-Reply-To: <1418733910-18253-1-git-send-email-declan.doherty@intel.com> References: <1418728549-31244-1-git-send-email-declan.doherty@intel.com> <1418733910-18253-1-git-send-email-declan.doherty@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2] bond: vlan flags misinterpreted in xmit_slave_hash function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Jan 2015 13:40:36 -0000 > This patch contains a fix for link bonding handling of vlan tagged packets in mode 3 and 5. > Currently xmit_slave_hash function misinterprets the PKT_RX_VLAN_PKT flag to mean that > there is a vlan tag within the packet when in actually means that there is a valid entry > in the vlan_tci field in the mbuf. > > -v2: > doxygen comments for rte_ip.h > > - Fixed VLAN tag support in hashing functions. > - Adds support for TCP in layer 4 header hashing. > - Splits transmit hashing function into separate functions for each policy to > reduce branching and to make the code clearer. > - Fixed incorrect flag set in test application packet generator. > > Signed-off-by: Declan Doherty Acked-by: Pawel Wodkowski Tested-by: SunX Jiajia Applied Thanks -- Thomas