From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f42.google.com (mail-wg0-f42.google.com [74.125.82.42]) by dpdk.org (Postfix) with ESMTP id D55BBC37A for ; Wed, 17 Jun 2015 01:38:31 +0200 (CEST) Received: by wgv5 with SMTP id 5so23644479wgv.1 for ; Tue, 16 Jun 2015 16:38:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=clC8sW53ikppA1maYUrjSJ38jWNTG4zjNLGySjAaLUQ=; b=ahd8OEmSqjkUEeeoi2Ylnpquo4tmlvxVJwSudtrlnFVa4juWVbLqE6XRYRYkMmrIot vL123JMJ3Gb56fUvDWVKNn6DXUqxBiWa8srB+e0lAHswipIjHM1v6wddNGohe2N2/ZXG IT0yZHfnaE8w5Hzaqu8DzrateDmlvRngqZpzzXeOGAUzjZW0DhtqzJtgIXjv3uBiFn5w a9gOkB1EkMTsBozq/FCQj5Nqhj4fTa8vC6Fm/pkdlky/GuHVlNa6Axt0+DZfmRcDns5I OelaEvC0+/22Yx5C/ijH76Nvho6hZt1vEvXYZeRf/nMaOCK47zGzEEWW05kZotQkfWyg 24Ww== X-Gm-Message-State: ALoCoQk5nvpxftsVFxnUvCJ9on8H3JLQaj/J96klc+NN80d1bBjZmNdzRUEU1P3OhzVU402MutYl X-Received: by 10.194.76.132 with SMTP id k4mr194507wjw.77.1434497911717; Tue, 16 Jun 2015 16:38:31 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id ma15sm23073225wic.20.2015.06.16.16.38.30 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 16 Jun 2015 16:38:30 -0700 (PDT) From: Thomas Monjalon To: Stephen Hemminger Date: Wed, 17 Jun 2015 01:37:32 +0200 Message-ID: <1777667.uJIdOE8Rh4@xps13> Organization: 6WIND User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; ) In-Reply-To: <20150616160512.03873f22@urahara> References: <1434387073-16951-1-git-send-email-stephen@networkplumber.org> <20150616135216.GA9780@bricha3-MOBL3> <20150616160512.03873f22@urahara> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org, Stephen Hemminger Subject: Re: [dpdk-dev] [PATCH 1/3] pmd_ring: remove deprecated functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Jun 2015 23:38:32 -0000 2015-06-16 16:05, Stephen Hemminger: > On Tue, 16 Jun 2015 14:52:16 +0100 > Bruce Richardson wrote: > > > On Mon, Jun 15, 2015 at 09:51:11AM -0700, Stephen Hemminger wrote: > > > From: Stephen Hemminger > > > > > > These were deprecated in 2.0 so remove them from 2.1 > > > > > > Signed-off-by: Stephen Hemminger > > > --- > > > drivers/net/ring/rte_eth_ring.c | 55 ------------------------------- > > > drivers/net/ring/rte_eth_ring_version.map | 4 +-- > > > 2 files changed, 1 insertion(+), 58 deletions(-) > > > > > [..snip..] > > > diff --git a/drivers/net/ring/rte_eth_ring_version.map b/drivers/net/ring/rte_eth_ring_version.map > > > index 8ad107d..5ee55d9 100644 > > > --- a/drivers/net/ring/rte_eth_ring_version.map > > > +++ b/drivers/net/ring/rte_eth_ring_version.map > > > @@ -1,9 +1,7 @@ > > > -DPDK_2.0 { > > > +DPDK_2.1 { > > > global: > > > > > > rte_eth_from_rings; > > > - rte_eth_ring_pair_attach; > > > - rte_eth_ring_pair_create; > > > > > > local: *; > > > }; > > > > [ABI newbie question] Is this how deprecating a fn is done? We no longer have any DPDK_2.0 > > version listings in the .map file? > > Notice the version # changed as well, so linker will generate a new version. > The function was marked deprecated in last version. What happens if you load the 2.1 lib with an app built for 2.0? Shouldn't we keep the DPDK_2.0 block?