From: Thomas Monjalon <thomas@monjalon.net>
To: Jacek Piasecki <jacekx.piasecki@intel.com>
Cc: dev@dpdk.org, maxime.coquelin@redhat.com, yliu@fridaylinux.org,
changpeng.liu@intel.com, stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v4] examples/vhost_scsi: fix buffer not terminated
Date: Wed, 25 Oct 2017 12:18:58 +0200 [thread overview]
Message-ID: <1778128.TuySi4b6Nz@xps> (raw)
In-Reply-To: <1508926038-12821-1-git-send-email-jacekx.piasecki@intel.com>
25/10/2017 12:07, Jacek Piasecki:
> Use snprintf instead strncpy to get safe null string termination.
> There was possible to get not terminated string after strncpy operation.
>
> Coverity issue: 158631
> Fixes: db75c7af19bb ("examples/vhost_scsi: introduce a new sample app")
> Cc: changpeng.liu@intel.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Jacek Piasecki <jacekx.piasecki@intel.com>
> Acked-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> ---
> v4: RTE_DIM instead ARRAY_SIZE
> v3: checkpatch fix
> v2: snprintf instead strncpy
Applied, thanks
prev parent reply other threads:[~2017-10-25 10:19 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-22 13:07 [dpdk-dev] [PATCH] " Michal Jastrzebski
2017-10-02 13:50 ` Jastrzebski, MichalX K
2017-10-02 15:07 ` Maxime Coquelin
2017-10-05 12:35 ` Piasecki, JacekX
2017-10-05 12:42 ` Maxime Coquelin
2017-10-05 13:01 ` Bruce Richardson
2017-10-05 13:02 ` Maxime Coquelin
2017-10-12 6:44 ` [dpdk-dev] [PATCH v2] " Jacek Piasecki
2017-10-12 11:09 ` Maxime Coquelin
2017-10-12 11:34 ` [dpdk-dev] [PATCH v3] " Jacek Piasecki
2017-10-13 7:12 ` Maxime Coquelin
2017-10-17 13:26 ` Yuanhan Liu
2017-10-24 16:22 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
2017-10-25 10:07 ` [dpdk-dev] [PATCH v4] " Jacek Piasecki
2017-10-25 10:18 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1778128.TuySi4b6Nz@xps \
--to=thomas@monjalon.net \
--cc=changpeng.liu@intel.com \
--cc=dev@dpdk.org \
--cc=jacekx.piasecki@intel.com \
--cc=maxime.coquelin@redhat.com \
--cc=stable@dpdk.org \
--cc=yliu@fridaylinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).