From: Thomas Monjalon <thomas@monjalon.net>
To: Anatoly Burakov <anatoly.burakov@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] fbarray: support no-shconf
Date: Tue, 22 May 2018 22:38:30 +0200 [thread overview]
Message-ID: <1778895.HHJToTI6Sl@xps> (raw)
In-Reply-To: <80aff8bc0255cdab2331dcb0b21219d50f154937.1527006762.git.anatoly.burakov@intel.com>
22/05/2018 18:35, Anatoly Burakov:
> When using --no-shconf option, the expectation is that no multiprocess
> will be supported as no shared files are created. However, fbarray
> still creates some shared files that prevent multiple processes with
> the same prefix from starting.
>
> Fix this by avoiding creating shared files whenever noshconf option is
> specified. Since virtual areas we get from eal_get_virtual_area() are
> read-only, remap them as writable.
>
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> ---
>
> Notes:
> Without this patch, EAL flags autotest will fail when attempting
> to run a test with the same prefix as primary, and --no-shconf
> specified.
>
> Technically, we never spelled out any guarantees about --no-shconf
> mode, and we've been sloppy about it, so even though we don't create
> the shared config, we still create lots of other miscelaneous files.
> This patch only fixes issue with fbarray, as this affects intialization
> of different primaries with the same prefix (fbarrays are shared too),
> but does not address the other instances where we create "shared" files
> such as hugepage info.
Just for confirmation: this patch won't be integrated in 18.05.
next prev parent reply other threads:[~2018-05-22 20:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-22 16:35 Anatoly Burakov
2018-05-22 20:38 ` Thomas Monjalon [this message]
2018-05-23 8:40 ` Burakov, Anatoly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1778895.HHJToTI6Sl@xps \
--to=thomas@monjalon.net \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).