From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 905631DA4 for ; Tue, 22 May 2018 22:38:32 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 1801321B36; Tue, 22 May 2018 16:38:32 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 22 May 2018 16:38:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=jGooR2+0mer7F1YhFWIz+5sm7m QOHqpnYOL9ctJVtNU=; b=RbG6Nurr5m/qCGcidT6dJw9191Rm9EdKdxKPAw3meL r+n6jpTY8qZ/CMDTt/NveRIbu7ZJICN1kv0Z+ARsyft0aadjkWE9y39eXlRNUX0C SF/tiVCzRKX8gKFWDGQQu0PFXFAj/k67Ig6WGpbY74DhmPqCCzL0AiUtqfxBV/ac k= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=jGooR2 +0mer7F1YhFWIz+5sm7mQOHqpnYOL9ctJVtNU=; b=MHLS6k3Jt34NLSmUBfhSKe aipEcd5TJLLyrKNnhpFDUdpm/mZryr9/6F9DYmpm1YI8eKmlhognvQWxRHaNnqfU 0pHsz6P6L/RE6AphQZ8+OL0cpLdZIgzP95/qQ8XJ64DBz4ijviIIyD/hJa0AWmS5 RHxg9XLYjSkq7k37yp/d1h3hevV6Uuy4ZrAeQl1ORMRNH8ecIrY9Lf2KbDTdwm+X e7fM4m2y2HzEmPGjbCswqy3ddv/wzT3MqgPr7nCgUeCYb7YGW57f4KluwQBgOBmD uzGX+MLZK2dvIb3buAiKazLpln2HsqZGGRjhM8EfyKSW7h3C/vrx5cvShB/HMWxQ == X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 7F10AE4910; Tue, 22 May 2018 16:38:31 -0400 (EDT) From: Thomas Monjalon To: Anatoly Burakov Cc: dev@dpdk.org Date: Tue, 22 May 2018 22:38:30 +0200 Message-ID: <1778895.HHJToTI6Sl@xps> In-Reply-To: <80aff8bc0255cdab2331dcb0b21219d50f154937.1527006762.git.anatoly.burakov@intel.com> References: <80aff8bc0255cdab2331dcb0b21219d50f154937.1527006762.git.anatoly.burakov@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] fbarray: support no-shconf X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 May 2018 20:38:32 -0000 22/05/2018 18:35, Anatoly Burakov: > When using --no-shconf option, the expectation is that no multiprocess > will be supported as no shared files are created. However, fbarray > still creates some shared files that prevent multiple processes with > the same prefix from starting. > > Fix this by avoiding creating shared files whenever noshconf option is > specified. Since virtual areas we get from eal_get_virtual_area() are > read-only, remap them as writable. > > Signed-off-by: Anatoly Burakov > --- > > Notes: > Without this patch, EAL flags autotest will fail when attempting > to run a test with the same prefix as primary, and --no-shconf > specified. > > Technically, we never spelled out any guarantees about --no-shconf > mode, and we've been sloppy about it, so even though we don't create > the shared config, we still create lots of other miscelaneous files. > This patch only fixes issue with fbarray, as this affects intialization > of different primaries with the same prefix (fbarrays are shared too), > but does not address the other instances where we create "shared" files > such as hugepage info. Just for confirmation: this patch won't be integrated in 18.05.