From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id CF83F1B4FF for ; Fri, 29 Jun 2018 18:15:09 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 2D83121DC0; Fri, 29 Jun 2018 12:15:09 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Fri, 29 Jun 2018 12:15:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=j6Mly+BaYdqxyxysL0iJQs83uY NHcxlMKqA8MkNMdNY=; b=Em50dSfpIyBDUCHj0vQASBbTVbPaMYfOqUYyv9wzOi xZ0ky2Td2EgJPJ4K1BgsI6BjJkAYGYKL2eg7CNGZ7UiXb/ppwo3esI7jD73kno/Z q80egtlyCtYx5oVUnW2bDJNefHwe53VpwsVGbDKiP+EzV0DrwwgsTRei+sqNPS0D g= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=j6Mly+ BaYdqxyxysL0iJQs83uYNHcxlMKqA8MkNMdNY=; b=B3oI0PZrmDz5MOGjK04LYk JwQcrUi/e47kMw55VYd88jnEVHhB4E6j9yxC+7dzdwI+zX4YQ1yhiv6a4V2O5FjN d1CHpiM9pw4Xj3EicLwc8fkoTWKMNHBu/+OSicqBvel8U2BiWmDoc4tiR6bVx9ek IuX8szQs+8IULh4k44YyvCpbXb4D8SZaBWCIX5HQQN3CMDe/u5W1zG/mTTVUIk1q cxBhFxHaEMa6wzogx0qhh4Vu/jyz4YWIXvtBofZWH3bHgrcmAHKmoMaLP7UTfI3C mLQcP1K/RM5WlRs0MeJxftnqw+blBjciswrv7oFrXq5IASfwynOGLcvsI+cS+CSA == X-ME-Proxy: X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 9A2A210262; Fri, 29 Jun 2018 12:15:07 -0400 (EDT) From: Thomas Monjalon To: Kevin Traynor Cc: dev@dpdk.org, Ferruh Yigit , john.mcnamara@intel.com, bluca@debian.org, yskoh@mellanox.com, christian.ehrhardt@canonical.com, aconole@redhat.com Date: Fri, 29 Jun 2018 18:15:06 +0200 Message-ID: <17794913.e2HM90q5a3@xps> In-Reply-To: References: <1529596827-14756-1-git-send-email-ktraynor@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] docs: add default that all fixes are backported X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Jun 2018 16:15:10 -0000 21/06/2018 18:45, Ferruh Yigit: > On 6/21/2018 5:00 PM, Kevin Traynor wrote: > > Set the starting point that all commits on master branch > > with Fixes tag are backported to relevant stable/LTS branches. > > > > Of course there will be exceptions that will crop up from time > > to time that need discussion, so also add a sentence for that. > > > > This is to ensure that there is consistency between what is > > backported to stable/LTS branches, remove some subjectivity > > as to what constitutes "a fix" and avoid possible conflicts > > for future backports. > > > > Signed-off-by: Kevin Traynor > > --- > > doc/guides/contributing/stable.rst | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/doc/guides/contributing/stable.rst b/doc/guides/contributing/stable.rst > > index 0f2f1f3..bbafc37 100644 > > --- a/doc/guides/contributing/stable.rst > > +++ b/doc/guides/contributing/stable.rst > > @@ -58,5 +58,7 @@ What changes should be backported > > --------------------------------- > > > > -Backporting should be limited to bug fixes. > > +Backporting should be limited to bug fixes. All patches accepted on the master > > +branch with Fixes tags will be backported to the relevant stable/LTS branches. > > +If there are exceptions, they will be discussed on the mailing lists. > > Just to highlight, there are some cased fix is not applicable for stable trees, > for that case "Cc: stable@dpdk.org" tag explicitly omitted. > > a) Fix with backport request: > Fixes: ############ ("...") > Cc: stable@dpdk.org > > b) Fix but backport not applicable/requested: > Fixes: ############ ("...") > > > So I agree there may be a confusion in b) if the backport is not requested or it > has been forgotten. > Is there anything we can do/change to help stable tree maintainers on this issue? I agree with Ferruh that fixes without Cc: stable@dpdk.org should not be backported, except if it is confirmed that it is a miss. Can we change the wording to "all patches with Cc: stable@dpdk.org tag" ?