DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: "Burakov, Anatoly" <anatoly.burakov@intel.com>
Cc: dev@dpdk.org, Damjan Marion <damarion@cisco.com>,
Subject: Re: [dpdk-dev] [PATCH 21.02 v2] mem: don't warn about base addr if not requested
Date: Fri, 28 Jan 2022 12:17:14 +0100	[thread overview]
Message-ID: <1780203.atdPhlSkOF@thomas> (raw)
In-Reply-To: <108cb3e3-3ca6-996d-9822-05dde4c657c1@intel.com>

22/01/2021 18:21, Burakov, Anatoly:
> On 09-Nov-20 3:47 PM, Anatoly Burakov wrote:
> > Any EAL memory allocation often goes through eal_get_virtual_area()
> > function, which will print a warning whenever the resulting allocation
> > didn't match the specified address requirements. This is useful for
> > when we have requested a specific base virtual address, to let the user
> > know that the mapping has deviated from that address.
> > 
> > However, on Linux, we also have a default base address that's there to
> > ensure better chances of successful secondary process initialization,
> > as well as higher likelihood of the virtual areas to fit inside the
> > IOMMU address width. Because of this default base address, there are
> > warnings printed even when no base address was explicitly requested,
> > which can be confusing to the user.
> > 
> > Emit this warning with debug level unless base address was explicitly
> > requested by the user.
> > 
> > Cc: Damjan Marion <damarion@cisco.com>
> > 
> > Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> > ---
> > 
> > Notes:
> >      v2:
> >      - Fix the condition to not update the address incorrectly
> >      - Instead of removing the warning, let it have debug level unless base address
> >        was explicitly specified by the user
> >      
> >      I'm not entirely sure the trade off between user confusion and helpful debug
> >      information is worth it, but in my experience, i've stopped getting any emails
> >      about secondary processes a long time ago and this isn't a widely used feature,
> >      so i believe this is worth it.
> For some reason i didn't get David's comment in my inbox, so i'll copy 
> it here:
>  > EAL options like --in-memory or --no-shconf makes MP unusable.
>  > If we add a rte_mp_disable() for them, we could check here for MP
>  > status here and display nothing at all.
>  > WDYT?
> That sounds like a nice idea, but this patch addresses a different issue.

I think it is the same issue, pushed further.
Anyway, let's take this patch (waiting for one year)
and wait for another one removing the log completely
in case secondary process is disabled.


      reply	other threads:[~2022-01-28 11:17 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-09 15:27 [dpdk-dev] [PATCH 21.02] " Anatoly Burakov
2020-11-09 15:47 ` [dpdk-dev] [PATCH 21.02 v2] " Anatoly Burakov
2021-01-12 10:29   ` David Marchand
2021-01-22 17:21   ` Burakov, Anatoly
2022-01-28 11:17     ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1780203.atdPhlSkOF@thomas \
    --to=thomas@monjalon.net \
    --cc=anatoly.burakov@intel.com \
    --cc=damarion@cisco.com \
    --cc=dev@dpdk.org \
    --cc=dmitry.kozliuk@gmail.com \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).