From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f47.google.com (mail-wg0-f47.google.com [74.125.82.47]) by dpdk.org (Postfix) with ESMTP id CEF42593A for ; Thu, 22 May 2014 17:28:48 +0200 (CEST) Received: by mail-wg0-f47.google.com with SMTP id x12so3505727wgg.6 for ; Thu, 22 May 2014 08:28:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=vNntuwhnFpEmR1KgZEzz4GruJaFHKPHSvo7zdCVAsQk=; b=cDleWjVlbCcGjBKOyKDrh+Da6mZDyKTRCaHOi7k9yP6ML3irtKpGNUR3agSfZfPE6S Xj/ZoYBQafgu9uRCFkVmSllK58NknCo4C+ogku2QSh+q/OgMOXEtiXMIBx1wLNqJU+rM son+MNR3XArxHug6dMOMbwg3sr9IbDqjaXjXwCFFetcZVdE2NPqCOJwa+tJ18imc6kdX 8qg0w2naMCZIKOOalEZxF4TN5e1cCw68iyXf3cLRaz+Yen/Z7PDxZsbBmZ5rNBhYDt2d YDa0vRkspSvYnxke4/6G8MWcUyfUMyKrDuLTdxtf+Zphmm+oFYoOJFLEp0f1wPtmPxnO ftYg== X-Gm-Message-State: ALoCoQkYcNmvqPgX4haFFMh6w4Q05i6r9Vpvw+zCd93ThGTU8cYsNB5+5I9+N3xpqDc6/dsZUu2Y X-Received: by 10.180.13.208 with SMTP id j16mr16894809wic.58.1400772538142; Thu, 22 May 2014 08:28:58 -0700 (PDT) Received: from xps13.localnet (6wind.net2.nerim.net. [213.41.180.237]) by mx.google.com with ESMTPSA id ek4sm898621wib.9.2014.05.22.08.28.55 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 22 May 2014 08:28:56 -0700 (PDT) From: Thomas Monjalon To: "Ouyang, Changchun" Date: Thu, 22 May 2014 17:28:53 +0200 Message-ID: <1780795.ydK3nqfa9Z@xps13> Organization: 6WIND User-Agent: KMail/4.13 (Linux/3.14.4-1-ARCH; KDE/4.13.0; x86_64; ; ) In-Reply-To: References: <1400512177-19315-1-git-send-email-changchun.ouyang@intel.com> <1478243.AGf3d0Vu1X@xps13> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] [PMD] [VHOST] Revert unnecessary definition and fix wrong referring in user space vhost zero copy patches X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 May 2014 15:28:49 -0000 Hi Changchun, Please, it is preferred to answer below the question. 2014-05-20 01:14, Ouyang, Changchun: > So "[PMD] [VHOST]" in the title should be removed in the cover letter, > right? And in each separate patch letter, it could use "ixgbe:" or > "examples/vhost:", instead of "[PMD] [VHOST]" Is it right? Yes, you did right in the v2. Thanks -- Thomas > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Tuesday, May 20, 2014 12:00 AM > To: Ouyang, Changchun > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] [PMD] [VHOST] Revert unnecessary definition > and fix wrong referring in user space vhost zero copy patches > > Hi Changchun, > > 2014-05-19 23:09, Ouyang Changchun: > > 1. Revert the change of metadata macro definition for referring to > > headroom space in mbuf; 2. Fix wrongly referring to RX queues number > > in TX queues start/stop function. > > > > Signed-off-by: Ouyang Changchun > > You are fixing commits which are not yet applied. > Please merge and re-send the whole serie by suffixing with "v2". > > The title was "[PATCH 0/3] [PMD] [VHOST] *** Support zero copy RX/TX in user > space vhost ***" It should be "[PATCH v2 0/3] Support zero copy RX/TX in > user space vhost" > > Other notes: > - please split API and ixgbe changes > - set a significant title to each patch > - use prefixes like "ethdev:", "ixgbe:" or "examples/vhost:" > > In general, this page is a good help: > http://dpdk.org/dev#send > > Thanks > -- > Thomas