From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wi0-f174.google.com (mail-wi0-f174.google.com
 [209.85.212.174]) by dpdk.org (Postfix) with ESMTP id 02B18C3B8
 for <dev@dpdk.org>; Thu, 23 Jul 2015 18:27:38 +0200 (CEST)
Received: by wicmv11 with SMTP id mv11so31476169wic.0
 for <dev@dpdk.org>; Thu, 23 Jul 2015 09:27:37 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=Izq47vbQMkL7D/G54+bwIR3YDzuLhULPeAgFrfI0Zqw=;
 b=LYzQosBSEgM+BEjSSah1Nn13zCjjLThotrb6d9pa88BEE/3ArkQpm5FyOj0+/0cCFm
 BIUVyF/6mTInqHk0XdZpfOhNH0PXv87rluqAn2tHX6GCuTG0k98kE6ytRl/c9j/2iJOs
 /zrPrm+LWH5E9OLZirErxfHbPzdpbwuthEGAg9wW94wthyyXMdAgzhLWsNKVpq9zGprk
 jJf4PSwupixEtlng1wQ4xOsftG4JrYGg+t9oDh3GLofkQ7AJyqNf2EJIypqJ1Qs+cZRU
 O64FApBh9edMu85jK6i+Bx5eMCOC/qp/nHPXmLEAhXu9TLF4tBmJQxn+vZB6se17dYP9
 mXfA==
X-Gm-Message-State: ALoCoQmlIqertgS4HZe1ggjk7KgDen5KnMCe5jruU6gzZ3xuIPCn/WII1TUmR4TEMNFb++9dpAwO
X-Received: by 10.180.187.195 with SMTP id fu3mr18961036wic.24.1437668857863; 
 Thu, 23 Jul 2015 09:27:37 -0700 (PDT)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by smtp.gmail.com with ESMTPSA id hd6sm27955827wib.19.2015.07.23.09.27.35
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Thu, 23 Jul 2015 09:27:36 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Konstantin Ananyev <konstantin.ananyev@intel.com>
Date: Thu, 23 Jul 2015 18:26:24 +0200
Message-ID: <1781257.Eo9CaUGVAh@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; )
In-Reply-To: <1437589735-30041-2-git-send-email-konstantin.ananyev@intel.com>
References: <1437589735-30041-1-git-send-email-konstantin.ananyev@intel.com>
 <1437589735-30041-2-git-send-email-konstantin.ananyev@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCHv4 1/5] ethdev: add new API to retrieve RX/TX
	queue information
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 23 Jul 2015 16:27:38 -0000

2015-07-22 19:28, Konstantin Ananyev:
> +	if (!rte_eth_dev_is_valid_port(port_id)) {
> +		PMD_DEBUG_TRACE("Invalid port_id=%d\n", port_id);
> +		return -EINVAL;
> +	}

Please use VALID_PORTID_OR_ERR_RET.

> + * Ethernet device RX queue information strcuture.

Typo here (and same for TX).

> +struct rte_eth_rxq_info {
> +	struct rte_mempool *mp;     /**< mempool used by that queue. */
> +	struct rte_eth_rxconf conf; /**< queue config parameters. */
> +	uint8_t scattered_rx;       /**< scattered packets RX supported. */
> +	uint16_t nb_desc;           /**< configured number of RXDs. */

Shouldn't we move nb_desc in rte_eth_rxconf?
So rte_eth_rx_queue_setup() would have less parameters.

> -#ifdef __cplusplus
> -}
> -#endif
> -
>  /**
>   * Set the list of multicast addresses to filter on an Ethernet device.
>   *
> @@ -3882,4 +3952,9 @@ extern int rte_eth_timesync_read_rx_timestamp(uint8_t port_id,
>   */
>  extern int rte_eth_timesync_read_tx_timestamp(uint8_t port_id,
>  					      struct timespec *timestamp);
> +
> +#ifdef __cplusplus
> +}
> +#endif
> +
>  #endif /* _RTE_ETHDEV_H_ */

Please send this change in a separate patch alone.