From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 02AD6A0508; Thu, 14 Apr 2022 15:26:16 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AD75D40694; Thu, 14 Apr 2022 15:26:16 +0200 (CEST) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id EC6BF40687 for ; Thu, 14 Apr 2022 15:26:15 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 9B6B85C01C0; Thu, 14 Apr 2022 09:26:15 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 14 Apr 2022 09:26:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1649942775; x= 1650029175; bh=No8gIoPEbR/mGOC2gsAAHbp8adOcH0ziY2qLRb64KWI=; b=M 3G0tmKZanOjYs/dwVU02vHJ1YqFJNgye59fIHrsMHbpWy8ZxKKb2UiDxdwiunT3L GMqNpMb0o+AJyHh1ZzA4Ne3cTghb56GahH6puE5N2HkqpBoboxGkBSb2jFTJtZij 8Gyee/BfQd7xxMTUopllMkZ/1M2jZWtWbib2qCF7OgPKqwlY6m25TmG9+lWHTYKF 9022xMogeTKZ4txOdBzSBZiqFzzBObvl/bWzoCIkNh1aTjnNOWHUnccoQf4or97U S6xQ892npbpM/kPQwodMJVr2p7zUchnxQpPHCLgciDw14ysMbB5BfQHQJcNGk4B3 n8E4JAm9Z37iXnM+H+4Nw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1649942775; x=1650029175; bh=No8gIoPEbR/mG OC2gsAAHbp8adOcH0ziY2qLRb64KWI=; b=gk/zBP6xxI+ZJ2Nye0yCWvy7Ff6os E7tW8p2FSJOUwHglyW9FVT+4J1DU5sjTd6iu+I6K695Pwvb3ilQygHZ93LzGNhsl h/jvihCUn7p0H2DlVEGb3v7o0fxs3ENzLPUjah7a9k7hbyKkfEONKiJPE2qTnHKT +Tbgb8tswmDCqy0wBXOhB1PLZM+EqpJZvuVfeDmeN8dRp+ni2v371vMC86Kg+gMb CJLrr5VIQhbndjUL/715ANtsk2+RJI8Xir90ikOqQG7KbhPXtU96aLSw8JBlddK3 f1SOJdefPlMMlW4fImjUKu1g6VNtLyeqvlHOD3+rQAdHi6GJMcGCav/Ow== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudelfedgieegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvffufffkjghfggfgtgesthfure dttddtvdenucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcuoehthhhomhgrshes mhhonhhjrghlohhnrdhnvghtqeenucggtffrrghtthgvrhhnpedugefgvdefudfftdefge elgffhueekgfffhfeujedtteeutdejueeiiedvffegheenucevlhhushhtvghrufhiiigv pedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrd hnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 14 Apr 2022 09:26:14 -0400 (EDT) From: Thomas Monjalon To: Huichao Cai Cc: dev@dpdk.org, konstantin.ananyev@intel.com, david.marchand@redhat.com, olivier.matz@6wind.com Subject: Re: [PATCH v6] ip_frag: add IPv4 options fragment and test data Date: Thu, 14 Apr 2022 15:26:13 +0200 Message-ID: <1781535.QCnGb9OGeP@thomas> In-Reply-To: <3987029.6PsWsQAL7t@thomas> References: <1647918560-14165-1-git-send-email-chcchc88@163.com> <1649649325-1942-1-git-send-email-chcchc88@163.com> <3987029.6PsWsQAL7t@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 14/04/2022 15:14, Thomas Monjalon: > 11/04/2022 05:55, Huichao Cai: > > According to RFC791,the options may appear or not in datagrams. > > They must be implemented by all IP modules (host and gateways). > > What is optional is their transmission in any particular datagram, > > not their implementation.So we have to deal with it during the > > fragmenting process.Add some test data for the IPv4 header optional > > field fragmenting. > > > > Signed-off-by: Huichao Cai > > You forgot the ack given on v5: > Acked-by: Konstantin Ananyev > > Applied, thanks. No sorry, it cannot be applied as-is. Some IP constants should be defined in lib/net/rte_ip.h and should be named RTE_IPV4_HDR_OPT_* for consistency.