From: Thomas Monjalon <thomas@monjalon.net>
To: Arnon Warshavsky <arnon@qwilt.com>
Cc: dev@dpdk.org, john.mcnamara@intel.com, marko.kovacevic@intel.com
Subject: Re: [dpdk-dev] [PATCH v2] devtools: check wrong svg include in guides
Date: Thu, 01 Nov 2018 10:27:01 +0100 [thread overview]
Message-ID: <1782447.EoLl64vPQU@xps> (raw)
In-Reply-To: <CAKy9EB3PL9vFV7H6xEwiskBcyQEfEXPfnV6xMv=XVoEUUwsFrQ@mail.gmail.com>
01/11/2018 07:45, Arnon Warshavsky:
> Hi
>
> >PS: the warning contains the regex. May it be improved?
>
> How about passing an explicit warning message to the awk instead of the
> regex?
Yes it is a good idea.
I think it can be a separate patch. Would you like to send it please?
[..]
> + if [ $? -ne 0 ] ; then
> + ret=1
> + fi
> +
> + return $ret
> }
>
> I also noticed that there is a need to keep the return value from each
> check in case the first fails and the latter succeeds
No need of return code.
The error is detected if there is something printed to stdout.
next prev parent reply other threads:[~2018-11-01 9:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-31 11:05 [dpdk-dev] [PATCH] devtools: check wrong svg include in patches Thomas Monjalon
2018-10-31 15:46 ` Arnon Warshavsky
2018-10-31 15:51 ` Thomas Monjalon
2018-10-31 15:55 ` Arnon Warshavsky
2018-10-31 16:28 ` [dpdk-dev] [PATCH v2] devtools: check wrong svg include in guides Thomas Monjalon
2018-11-01 6:45 ` Arnon Warshavsky
2018-11-01 9:27 ` Thomas Monjalon [this message]
2018-11-01 9:29 ` Arnon Warshavsky
2018-11-01 13:59 ` Arnon Warshavsky
2018-11-01 14:10 ` Thomas Monjalon
2018-11-01 21:25 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1782447.EoLl64vPQU@xps \
--to=thomas@monjalon.net \
--cc=arnon@qwilt.com \
--cc=dev@dpdk.org \
--cc=john.mcnamara@intel.com \
--cc=marko.kovacevic@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).