From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id 62537A00C5;
Sun, 26 Apr 2020 17:38:28 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id AB7BB1BF9D;
Sun, 26 Apr 2020 17:38:27 +0200 (CEST)
Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com
[66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 155681BF8E
for <dev@dpdk.org>; Sun, 26 Apr 2020 17:38:26 +0200 (CEST)
Received: from compute7.internal (compute7.nyi.internal [10.202.2.47])
by mailout.nyi.internal (Postfix) with ESMTP id A22275C0106;
Sun, 26 Apr 2020 11:38:25 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
by compute7.internal (MEProxy); Sun, 26 Apr 2020 11:38:25 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
from:to:cc:subject:date:message-id:in-reply-to:references
:mime-version:content-transfer-encoding:content-type; s=fm1; bh=
KKLOx8j9ahbTEREEbFgR0jIVZ/FPRDphxqljUyIFnMc=; b=tZaOzQCFxGZ1CbCD
OmGyJwsjTEsqA7gxmxK8v11JOa1CgZNQRsLydzfAVsFzMxuDB7tJ5CH4kr1TJpAL
LgAsVnUpmB2u7C5vCiV6M67QZnudY6hB+SwHPH11aLrN7RT8Mtp7VVWnrK11UVGt
g5kb/+XkalLOJIUZqRxNPpv8aaGhjqYxqvJqwPahvvr8Tn+KrqwLi4IRhOGopqeP
b9DdriJDorg4Dg6Ox2Yh1OtP5y9xDKW7y0FqyDw6SC1Q1pc1ddo2YlgSYV6vuDBv
a0046AzBbR5F0gWorPdTi64cMearn/mkPovybrbj/gtv286AC3/U55RrhRlygJ2N
P93XCQ==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:content-transfer-encoding:content-type
:date:from:in-reply-to:message-id:mime-version:references
:subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
:x-sasl-enc; s=fm2; bh=KKLOx8j9ahbTEREEbFgR0jIVZ/FPRDphxqljUyIFn
Mc=; b=TylG7C86E59swcT02FmZvT6GUdg/igcLyvbGPugK9yeFT9Iaceu0G9kUO
dPVN/fu5u70C0hhbdJrR8sIRZSy6XShMpY+gj50+wT3lHX0wcYjdWUsttQ0nuCAA
rT/RIKy2sbN/u4hkWLrUhWLhHDWHSgtyAWYS3DJf6LN3OuEiuuxmjIuJDlOQZkKP
tVnWzHcLGPiXSFY9BFon6tWrn1tscQaTE9HpvfBxmmYkNlZv2gGDZkKHa7x5kh95
R2rKNhJylpxunmyzMXvhCYL/IXidf+8BUWTIvjeKhh0x6huFzy4iNVJzlePz1ZNC
Hn7MW7qmmv0yttKf8pPU4HeS6/+0g==
X-ME-Sender: <xms:8aqlXjbrdSz2Rnes4kxQY2aKje59mgJykkh5BTHejaqcmLgpoUzoOQ>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrheejgdelvdcutefuodetggdotefrodftvf
curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu
uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc
fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs
ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph
epjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghr
rghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth
X-ME-Proxy: <xmx:8aqlXo-z9Z5c_HdT4dAiy4ED53-oEYYWDlwmxu56ulRLh0-0SleM5w>
<xmx:8aqlXnpLpwx008ABIkyJjNNdKEAcAWlNKK7x7u92eLT6Fy-14tDrCA>
<xmx:8aqlXjERcsNHZtRTIsXlZh0ZQY_7FTT23xpYvTcr6i5LDNdi4eHXMQ>
<xmx:8aqlXn8iBtTB9nIodN71Gwhad34GrljZygA-fdS7BmKEfDeP6Whycg>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
by mail.messagingengine.com (Postfix) with ESMTPA id EAF00328005E;
Sun, 26 Apr 2020 11:38:23 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Cc: dev@dpdk.org, Pallavi Kadam <pallavi.kadam@intel.com>,
Narcisa Ana Maria Vasile <Narcisa.Vasile@microsoft.com>,
Ranjit Menon <ranjit.menon@intel.com>,
Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>, Jerin Jacob <jerinj@marvell.com>,
Sunil Kumar Kori <skori@marvell.com>,
Harini Ramakrishnan <harini.ramakrishnan@microsoft.com>,
Omar Cardona <ocardona@microsoft.com>,
David Marchand <david.marchand@redhat.com>
Date: Sun, 26 Apr 2020 17:38:22 +0200
Message-ID: <17842859.gIjEHFZm8d@thomas>
In-Reply-To: <20200426152819.2496610-4-dmitry.kozliuk@gmail.com>
References: <20200426032245.2437733-1-dmitry.kozliuk@gmail.com>
<20200426152819.2496610-1-dmitry.kozliuk@gmail.com>
<20200426152819.2496610-4-dmitry.kozliuk@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v2 3/3] eal/windows: fix build by enabling
trace compilation
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
I think this patch is doing too many things at once.
Why not just disabling tracing on Windows for now,
and apply proper patches for memory management, timer, endianness, etc
in 20.08?
Some cosmetic comments below,
26/04/2020 17:28, Dmitry Kozlyuk:
> Replace clock_gettime(CLOCK_REALTIME) with C11 timespec_get().
> Implementation is provided for MinGW-w64 that misses this function.
>
> Provide minimum viable implementations of malloc and timer functions
> used by tracing. Regex stubs are already present in Windows EAL.
>
> Fixes: 185b7dc1d467 ("trace: save bootup timestamp")
> Fixes: 321dd5f8fa62 ("trace: add internal init and fini interface")
> Reported-by: Pallavi Kadam <pallavi.kadam@intel.com>
> Signed-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Blank line is required between "Fixes" block and " Reported/SoB".
[...]
> --- a/lib/librte_eal/include/generic/rte_byteorder.h
> +++ b/lib/librte_eal/include/generic/rte_byteorder.h
> -#ifdef RTE_EXEC_ENV_FREEBSD
> +#if defined(RTE_EXEC_ENV_FREEBSD)
No need to change above line.
> #include <sys/endian.h>
> -#else
> +#elif defined(RTE_EXEC_ENV_LINUX)
Parenthesis are useless.
> #include <endian.h>
> #endif