From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f177.google.com (mail-wi0-f177.google.com [209.85.212.177]) by dpdk.org (Postfix) with ESMTP id 5C206C6FA for ; Mon, 22 Jun 2015 17:34:17 +0200 (CEST) Received: by wibdq8 with SMTP id dq8so79163876wib.1 for ; Mon, 22 Jun 2015 08:34:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=GX/ZDhv6s57PgaEKIgu1KyCCbX2Ldvn+Xol1ow5EG3Y=; b=HkyGTLLZMY7NYWTz2FnSfUf/+IC6qs07gdMv7elP9PgyY6o4Eq9vf7iqUwiB9zIWo4 ICf+PpznsPdGvxh0+CACR1wFYax9gQyKs0KoJsSWaVUdZyGqTwPh899MKul++SSQAlDk lfppcVrPWUh6l/Zhh6gLkALuqr9iY3+cHyR89oyc3c9qmulsKQWnRrHpjUILvTf1Mu5g ZWLrfYIbvdy/yGfIx8G47l5YYsYTQRLVhe3yH51miVbt5Ho5yAUtBJIi/DD7Q0COvIHd xoOma1S7iV3bmwqZYDv1wEVeqUnXCr9Zw7XkUE0Of1em3WZ2ArTXtjuS6QA3ANj626EE xG3g== X-Gm-Message-State: ALoCoQlAK2U6JvoIa3FguVnHAV0tu3KgSMe0+c1RA1UZfjPQg2bGldwWaETo3OYj75E445WK6NA6 X-Received: by 10.194.59.212 with SMTP id b20mr10722532wjr.31.1434987257275; Mon, 22 Jun 2015 08:34:17 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id s10sm31136466wjy.35.2015.06.22.08.34.15 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 22 Jun 2015 08:34:16 -0700 (PDT) From: Thomas Monjalon To: Bruce Richardson Date: Mon, 22 Jun 2015 17:33:15 +0200 Message-ID: <1784806.DNuCGtV9V3@xps13> Organization: 6WIND User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; ) In-Reply-To: <1434634121-24036-1-git-send-email-bruce.richardson@intel.com> References: <1434634121-24036-1-git-send-email-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] pmd_ring: return new port id on ethdev creation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Jun 2015 15:34:17 -0000 > The rte_eth_from_rings API allowed the creation of an ethdev port at > runtime using rte_rings as the underlying storage. However, the return > value from this function was either 0 or -1, and these values were never > actually documented in the API documentation. Unfortunately, the programmers > guide doc examples for this API implied that the return value from this > function was the port id of the newly created ethdev. > > Since this latter behaviour is more useful - and already implied by the > documentation, this patch changes the return 0 to "return > data->port_id". It also adds in doxygen comments for the function so it > can be correctly documented in the API reference. > > Signed-off-by: Bruce Richardson Applied, thanks