From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f169.google.com (mail-wi0-f169.google.com [209.85.212.169]) by dpdk.org (Postfix) with ESMTP id 701F2312 for ; Mon, 19 May 2014 11:18:15 +0200 (CEST) Received: by mail-wi0-f169.google.com with SMTP id hi2so4857657wib.4 for ; Mon, 19 May 2014 02:18:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=FAt74S4wAt7PcYGS+bz3nqqbVMZwKj9cbSU9FEwkhdk=; b=CT8bL6JgJ9KsakzpWVAcnufJiKUJb3rXYDXEThRIvlcVFujl5bgBqKrkIAS/oxy8Dh lp4PHZcVwSVq9xtJ9r4eQpX85rYQKGK6cVXIPK5wk8wWeCClz08ZJ6f3ZrQMcpSGud1H tZ+XGlUU/6xE83IQNscOh7Zab8BAN4nA8o8Av6yP+B+52vZ2vQaDiagUJskOGd08dVTS QDvWubeoRMfrB2djfGYQbUouPL9VsqKTE4br6MeQBH1wBZMT0Wb/TtL0W5/gPzmGG2or ZFoGD/evbsi97aanR6biSbzae0v9vdvF4c+Kbn+Gew/R/1SK2+xiSqDCNqRqcEsAdmG6 TFnw== X-Gm-Message-State: ALoCoQmE7J3to0aMiCGBypt3CrUqarlyB9KPjN+RXQU0tI9IwDApD8MvhS//OICRKtaD4rUdBBm1 X-Received: by 10.180.211.36 with SMTP id mz4mr11862366wic.20.1400491104111; Mon, 19 May 2014 02:18:24 -0700 (PDT) Received: from xps13.localnet (6wind.net2.nerim.net. [213.41.180.237]) by mx.google.com with ESMTPSA id l9sm13994037wic.21.2014.05.19.02.18.21 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 19 May 2014 02:18:22 -0700 (PDT) From: Thomas Monjalon To: Jijiang Liu Date: Mon, 19 May 2014 11:18:18 +0200 Message-ID: <1789529.RGC5GB4S3q@xps13> Organization: 6WIND User-Agent: KMail/4.13 (Linux/3.14.4-1-ARCH; KDE/4.13.0; x86_64; ; ) In-Reply-To: <1400120294-15871-1-git-send-email-jijiang.liu@intel.com> References: <1400120294-15871-1-git-send-email-jijiang.liu@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 0/3] *** Upgrade NIC share codes *** X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 May 2014 09:18:15 -0000 Hi Jijiang, I feel there is a lot of important changes in these patches but I cannot easily read them. Splitting in many small patches with nice commit logs would help a lot. Please refer to http://dpdk.org/dev#send in order to understand what must be a good patch. At least, you should make patches for minor changes (whitespace/typo/case), few patches for new features (e.g. M88E1512, SFP+ laser) and few patches for bug fixes (e.g. pll_workaround_i210, locks, fc-autoneg, vf link). Especially, an explanation is needed for locking changes as there were some work on it in these commits: http://dpdk.org/browse/dpdk/commit/?id=4c9d8ed203c1170e4cc11 http://dpdk.org/browse/dpdk/commit/?id=f283b30509d2db745e746 "git add -p" could help you to split the changes into several commits. You can check how minor changes in base driver were handled previously. Examples from version 1.5.1: http://dpdk.org/browse/dpdk/commit/?id=1558bea6e3723d9c1 http://dpdk.org/browse/dpdk/commit/?id=2fd4855f306e9df38 http://dpdk.org/browse/dpdk/commit/?id=5037620be576a3c20 http://dpdk.org/browse/dpdk/commit/?id=1d2d65121bd10ba95 Thanks -- Thomas