From: Thomas Monjalon <thomas@monjalon.net>
To: Martin Havlik <xhavli56@stud.fit.vutbr.cz>,
Ferruh Yigit <ferruh.yigit@intel.com>,
"Min Hu (Connor)" <humin29@huawei.com>,
Ajit Khaparde <ajit.khaparde@broadcom.com>,
Xueming Li <xuemingl@nvidia.com>, Bing Zhao <bingz@nvidia.com>,
Chengchang Tang <tangchengchang@huawei.com>,
dev@dpdk.org, orika@nvidia.com
Cc: Jan Viktorin <viktorin@cesnet.cz>,
dev@dpdk.org, chas3@att.com, haiyue.wang@intel.com,
ivan.ilchenko@oktetlabs.ru, aman.deep.singh@intel.com,
kirankn@juniper.net, lirongqing@baidu.com,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Subject: Re: [dpdk-dev] [PATCH 1/2] lib/ethdev: introduce RTE_ETH_DEV_CAPA_FLOW_CREATE_BEFORE_START
Date: Mon, 26 Sep 2022 16:38:42 +0200 [thread overview]
Message-ID: <17895984.sWSEgdgrri@thomas> (raw)
In-Reply-To: <9bd1d5b2-3372-3f48-e739-ef4e5a8689ae@oktetlabs.ru>
There was no follow up to this patch.
Ori, could you give your opinion please?
12/10/2021 14:02, Andrew Rybchenko:
> Summary prefix should be just "ethdev: " and summary should
> be human readable. It should not refer to defines etc.
>
> On 10/5/21 8:19 PM, Martin Havlik wrote:
> > Not all PMDs allow RTE flow rules to be created before start.
> > This capability will be set for the ones that allow it.
> >
> > Signed-off-by: Martin Havlik <xhavli56@stud.fit.vutbr.cz>
> > ---
> > lib/ethdev/rte_ethdev.h | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h
> > index bef24173cf..3115a6fccf 100644
> > --- a/lib/ethdev/rte_ethdev.h
> > +++ b/lib/ethdev/rte_ethdev.h
> > @@ -1448,6 +1448,8 @@ struct rte_eth_conf {
> > #define RTE_ETH_DEV_CAPA_RUNTIME_RX_QUEUE_SETUP 0x00000001
> > /** Device supports Tx queue setup after device started. */
> > #define RTE_ETH_DEV_CAPA_RUNTIME_TX_QUEUE_SETUP 0x00000002
> > +/** Device supports RTE Flow rule creation before device start. */
> > +#define RTE_ETH_DEV_CAPA_FLOW_CREATE_BEFORE_START 0x00000004
> > /**@}*/
> >
> > /*
> >
>
>
> I think that rte_flow_create() should check
> the capability in !dev->data->dev_started case
> and return error if capability is not advertised.
> The only problem here is to avoid dev_info get on
> each rte_flow_create() call.
>
prev parent reply other threads:[~2022-09-26 14:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-05 17:19 Martin Havlik
2021-10-06 17:13 ` Ajit Khaparde
2021-10-12 12:02 ` Andrew Rybchenko
2022-09-26 14:38 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17895984.sWSEgdgrri@thomas \
--to=thomas@monjalon.net \
--cc=ajit.khaparde@broadcom.com \
--cc=aman.deep.singh@intel.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=bingz@nvidia.com \
--cc=chas3@att.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=haiyue.wang@intel.com \
--cc=humin29@huawei.com \
--cc=ivan.ilchenko@oktetlabs.ru \
--cc=kirankn@juniper.net \
--cc=lirongqing@baidu.com \
--cc=orika@nvidia.com \
--cc=tangchengchang@huawei.com \
--cc=viktorin@cesnet.cz \
--cc=xhavli56@stud.fit.vutbr.cz \
--cc=xuemingl@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).