From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AF8FFA00C2; Mon, 26 Sep 2022 16:38:49 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9894C40DF7; Mon, 26 Sep 2022 16:38:49 +0200 (CEST) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by mails.dpdk.org (Postfix) with ESMTP id C68B34069B for ; Mon, 26 Sep 2022 16:38:47 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 7B7C05C00D1; Mon, 26 Sep 2022 10:38:47 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Mon, 26 Sep 2022 10:38:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1664203127; x= 1664289527; bh=/8aV+9OGYCcerNHDiMzr3ekedhDt9UqInJ3i2O8vI+0=; b=Q Lq2Ad1S1tMdVLhRIoo5zKoBO/hQIJM7vREPA6AyWhHKG0iNkEWNNFJrvSDD48Fyh nPFTv5ENwJbUb3nTXxETl7q0TAPWPMszzwcSaN5bPuLZzA0ZhPsb4CaQKB6nog/9 g+0pjH1vzQ9LjNg855IqhKZHAhA9rbD9qs9Rnx/M/M9y8DqoTkTgP5QSynAxPkZw m8uYP3zWtdP7aJ5a6efUIS6dMlHxSCfh+OloWWfr9igkZeXrSHHd6hvbhha315N3 E0JfqYhz25PkhHl713HG2BPIc2P5KYP96dkx/wBc8YkoAhBsGD8CIipCjSs6fBTg qNkz62Z8dEZ+kquc58gtg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1664203127; x= 1664289527; bh=/8aV+9OGYCcerNHDiMzr3ekedhDt9UqInJ3i2O8vI+0=; b=f 6Oki5Thv+yagTguLqmDCEuo8vXDOzTucKLk5wzqERqJNVzGyWVAWSC+7i5/UkDYQ OrLPhNAgqekbigJor4R8tyaG2pr+0sskcB0qohLaKiNALE8vBhw1J5axIuACAdrX hYLLXkxvTjWpfmG6WCGWyVRNgkMWZAvav9DDvZW192oiPKIYLNt/LIXg+W4bjcvU Zyhe+7upap1iqfjsAm0DDTDkRA24l8MQmdzKk60Q6p2U6g5R5f9kdsER8qZasDdU 7Y1ZA4bRc+MXClVT+qiQpYmaombOeUdxs1Cl/e2/HYVQme9z0BXsrkKEpRe0FDot D2ZEOJwNZWOIwIsJ3Mbxw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeegvddgjeelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 26 Sep 2022 10:38:43 -0400 (EDT) From: Thomas Monjalon To: Martin Havlik , Ferruh Yigit , "Min Hu (Connor)" , Ajit Khaparde , Xueming Li , Bing Zhao , Chengchang Tang , dev@dpdk.org, orika@nvidia.com Cc: Jan Viktorin , dev@dpdk.org, chas3@att.com, haiyue.wang@intel.com, ivan.ilchenko@oktetlabs.ru, aman.deep.singh@intel.com, kirankn@juniper.net, lirongqing@baidu.com, Andrew Rybchenko Subject: Re: [dpdk-dev] [PATCH 1/2] lib/ethdev: introduce RTE_ETH_DEV_CAPA_FLOW_CREATE_BEFORE_START Date: Mon, 26 Sep 2022 16:38:42 +0200 Message-ID: <17895984.sWSEgdgrri@thomas> In-Reply-To: <9bd1d5b2-3372-3f48-e739-ef4e5a8689ae@oktetlabs.ru> References: <20211005171914.2936-1-xhavli56@stud.fit.vutbr.cz> <9bd1d5b2-3372-3f48-e739-ef4e5a8689ae@oktetlabs.ru> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org There was no follow up to this patch. Ori, could you give your opinion please? 12/10/2021 14:02, Andrew Rybchenko: > Summary prefix should be just "ethdev: " and summary should > be human readable. It should not refer to defines etc. > > On 10/5/21 8:19 PM, Martin Havlik wrote: > > Not all PMDs allow RTE flow rules to be created before start. > > This capability will be set for the ones that allow it. > > > > Signed-off-by: Martin Havlik > > --- > > lib/ethdev/rte_ethdev.h | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h > > index bef24173cf..3115a6fccf 100644 > > --- a/lib/ethdev/rte_ethdev.h > > +++ b/lib/ethdev/rte_ethdev.h > > @@ -1448,6 +1448,8 @@ struct rte_eth_conf { > > #define RTE_ETH_DEV_CAPA_RUNTIME_RX_QUEUE_SETUP 0x00000001 > > /** Device supports Tx queue setup after device started. */ > > #define RTE_ETH_DEV_CAPA_RUNTIME_TX_QUEUE_SETUP 0x00000002 > > +/** Device supports RTE Flow rule creation before device start. */ > > +#define RTE_ETH_DEV_CAPA_FLOW_CREATE_BEFORE_START 0x00000004 > > /**@}*/ > > > > /* > > > > > I think that rte_flow_create() should check > the capability in !dev->data->dev_started case > and return error if capability is not advertised. > The only problem here is to avoid dev_info get on > each rte_flow_create() call. >