From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D62B8A0A02; Thu, 14 Jan 2021 19:49:45 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B3A57140D09; Thu, 14 Jan 2021 19:49:45 +0100 (CET) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by mails.dpdk.org (Postfix) with ESMTP id EEC96140CF2; Thu, 14 Jan 2021 19:49:43 +0100 (CET) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 852AC5C0081; Thu, 14 Jan 2021 13:49:41 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Thu, 14 Jan 2021 13:49:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= WQthlE20ms0ZXQjy0eNpMPub1gSUkZfLYRJDKuhjsG8=; b=NCs0Llq5Ldao6KlL 063zo+2NueL1R3N0n7RkJJMrUReiKtwXx8gBNqdzwszH4Y4UuA1RKGLSVywDUdxM n5zWXw0cOWYzJNFPUh0sEu3EKpKxREGSdF/+X9RylRuxIZxOVSeB72GritwtQ0z0 Gde2NvxIG04NC92w2KMNL6QZp4rCYTMfrnmT7K7OM8FxGCZd9w8o6KSr+LHgayks bOI72W8xkIvunLpTPziLHHNiMkZ4nPO4/5EWtexl9regrypuYy2yYBx/4ANHti8c yKLpJ36aTSQ6lAHEgfEEPAu86Lui+XTwQwqBCy7GZvHMAlX6Z1AAaG7KGjBVRT7W KrjtrA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=WQthlE20ms0ZXQjy0eNpMPub1gSUkZfLYRJDKuhjs G8=; b=X7O+aKSxUEElP5spqbb4EbluXJbLVWEC+BQH/UJUJn2lhfNd0UEtH6FNw dOE7CeEXPPv6mJt08DbzCf0rDFT/kmr2Ckr/Ho5lmvgUEhER+r5JAgjKvm2gOtj3 b5WRbb0WmhiQ+rt9aIjP26gbQJ+ghuVckFd15YCSAkBgmzXUCf4llh/2Ytz2l7V8 FIKaKYKzCj4qUpQTScWGWjZIZpKpQEYXAH95djKSNsOJmfN8ZlXkPu5pdSGVrnLu ABwie3deTmwsn273rAOhzXO2rHMK2lcMWHd8wDU/Gm+k417fUdJO8SP1K4iJggrp 0gWxtZS+t3tKEQerl930yxnK9NYMw== X-ME-Sender: <xms:RZIAYMATt1PfUc5HfhH4I60o6Of-zgrjs5RmkFJgpLrLPKfCEmcnoA> <xme:RZIAYOgEqB2KmoNCJLfmILF1sJuKoxPX4WF4p0UZLlattExe5ugD9jyJZjPkxLXjC fHgzdXGrgILSxzPYQ> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrtddtgdelfecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: <xmx:RZIAYPneMkImhZWD7UQyPTi4-MgpEHgTIGvl2WMmzCy8ZMIC7rCd3w> <xmx:RZIAYCwSbKSaYIKPnCincEkxrvM6c_gK203yOoFLTWL_MtJXSTOQSA> <xmx:RZIAYBQJKz8wlaWq37B5-iGtID5K91MbbT69rxSm7nq6-a2OtvwhwQ> <xmx:RZIAYDf8Sfrs1ksnG3n6vv7zde6P9MmDJvFyXG1LI0ys9-5vVTQU2w> Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 7F17E24005B; Thu, 14 Jan 2021 13:49:40 -0500 (EST) From: Thomas Monjalon <thomas@monjalon.net> To: Bruce Richardson <bruce.richardson@intel.com>, Tyler Retzlaff <roretzla@linux.microsoft.com>, Dmitry Kozlyuk <dmitry.kozliuk@gmail.com> Cc: dev@dpdk.org, navasile@linux.microsoft.com, stable@dpdk.org Date: Thu, 14 Jan 2021 19:49:38 +0100 Message-ID: <178962143.vrpKgbl6Nm@thomas> In-Reply-To: <20210114212740.3d69dbc2@sovereign> References: <1610414325-9104-1-git-send-email-roretzla@linux.microsoft.com> <20210114105554.GA1959@bricha3-MOBL.ger.corp.intel.com> <20210114212740.3d69dbc2@sovereign> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] eal/headers: explicitly cast void * to type * X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> 14/01/2021 19:27, Dmitry Kozlyuk: > > > If it's a public header then maybe it's missing a @file? > > > > > My 2c on this in general... > > > > The use of public vs private headers is not always clear, sadly, in DPDK, > > for historical reasons. With the make builds, libraries picked up headers > > from other libraries via the "include" folder for all of DPDK, meaning that > > if a particular header was internal only but used by multiple other libs, > > it was placed in "include" for simplicity, rather than having each library > > using it having to have separate "-I/path/to/header" cflags specified. > > With the switch to meson, this common folder use is no longer be the case, > > but because of the old way of doing things it may be that in the transition > > some private headers were inadvertently kept as public (and possibly vice > > versa, though that is more likely to be spotted by now). > > > > /Bruce > > Here is why rte_ethdev_pci.h should be considered private to DPDK: > > * rte_eth_copy_pci_info - intended for device init, that is, driver job > * eth_dev_pci_specific_init - wrapper for the above > * rte_eth_dev_pci_allocate - @internal, deals with private data > * rte_eth_dev_pci_generic_probe - @internal, deals with private data > * rte_eth_dev_pci_generic_remove - @internal Yes rte_ethdev_pci.h is a helper for ethdev drivers, it is DPDK internal.