From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 247D1A00C3; Fri, 15 May 2020 15:31:46 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 062891DAFD; Fri, 15 May 2020 15:31:45 +0200 (CEST) Received: from new3-smtp.messagingengine.com (new3-smtp.messagingengine.com [66.111.4.229]) by dpdk.org (Postfix) with ESMTP id 1E6111DAF9; Fri, 15 May 2020 15:31:43 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailnew.nyi.internal (Postfix) with ESMTP id A6E6F58024D; Fri, 15 May 2020 09:31:42 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Fri, 15 May 2020 09:31:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= FQE4mBfcwgrNcc8TNBVoqz8MuvyzAqmoOKuqXzlgftE=; b=aUnA86SkbognI4Za 4r1VV7P62PWnsf7EN8UUkjpjJY1YAd73tcxXvmtk54aw1vPp7a6aHtotf1cB5SGL s3PnlvqwIsT8gY4/iDOnC5/S6P04Y+JbIsGrS7ZuVn9vgtnpOakyrByZAHNkitfj 5eDmu5ydjZV4ICtEMxiFBmaRoAmDFptrZHQdlD2JZ12sJmzqXoWIvAnI8wa7R2aW B6DbVK2ukrerKFqEme2j2c7dVmh1bSrhJDuLDoRO9DRzhIXJPefOSEeF++hFlk2H md/KDo1HvA2CFKYWBNydHzewRcY2wGk3QHBBONbsrzX1liW9R8KcM69KWwc/UoSD wSFDGQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=FQE4mBfcwgrNcc8TNBVoqz8MuvyzAqmoOKuqXzlgf tE=; b=yYikg5X7fAyVoFPeDWC8SitALM2uZGdinzrb8iK+c96/m7OeOr2KbpA/j dHnhaq8V2RHfOEV+cbXbU+OteX+cjwWvgYbb+V4wSAg2nieW0eQJfkTUzeFkGNRC rUFyibw+rDLCRpYN7cacTp1f6ACvZU1kOaHdR0qCn0DTGnFkDYOyD5aLqueNE8db Pgxy8b9/0sIqXUtpQttm0TnTP6pb6RJ+AV/yhwa9yEGPKmOAsyrh2gvwewYAr7Kg L8O/ESB8dAANBTMdSkokx1KC2O9tdVOyhQBhbRhmIf2MaGG2RoYXNoSQ4o9Z0/fT aOnFZQJm8CSezSU9ODATLtgSvnFxA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrleekgdeifecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpeffvdffjeeuteelfeeileduudeugfetjeelveefkeejfeeigeehteff vdekfeegudenucffohhmrghinhepughpughkrdhorhhgnecukfhppeejjedrudefgedrvd dtfedrudekgeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhr ohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 1340F3280065; Fri, 15 May 2020 09:31:37 -0400 (EDT) From: Thomas Monjalon To: Ray Kinsella , Ferruh Yigit Cc: Neil Horman , Cristian Dumitrescu , Eelco Chaudron , dev@dpdk.org, David Marchand , stable@dpdk.org, Luca Boccassi , Bruce Richardson , Ian Stokes , Andrzej Ostruszka Date: Fri, 15 May 2020 15:31:35 +0200 Message-ID: <1791170.VZ3vTMCxA0@thomas> In-Reply-To: <20200514161104.1546493-1-ferruh.yigit@intel.com> References: <20200513121149.2283385-1-ferruh.yigit@intel.com> <20200514161104.1546493-1-ferruh.yigit@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v4] meter: provide experimental alias of API for old apps X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 14/05/2020 18:11, Ferruh Yigit: > On v20.02 some meter APIs have been matured and symbols moved from > EXPERIMENTAL to DPDK_20.0.1 block. > > This can break the applications that were using these mentioned APIs on > v19.11. Although there is no modification on the APIs and the action is > positive and matures the APIs, the affect can be negative to > applications. > > Since experimental APIs can change or go away without notice as part of > contract, to prevent this negative affect that may occur by maturing > experimental API, a process update already suggested, which enables > aliasing without forcing it: > https://patches.dpdk.org/patch/65863/ > > This patch provides aliasing by duplicating the existing and versioned > symbols as experimental. > > Since symbols moved from DPDK_20.0.1 to DPDK_21 block in the v20.05, the > aliasing done between EXPERIMENTAL and DPDK_21. > > Also following changes done to enabling aliasing: > > Created VERSION_SYMBOL_EXPERIMENTAL helper macro. > > Updated the 'check-symbols.sh' buildtool, which was complaining that the > symbol is in EXPERIMENTAL tag in .map file but it is not in the > .experimental section (__rte_experimental tag is missing). > Updated tool in a way it won't complain if the symbol in the > EXPERIMENTAL tag duplicated in some other block in .map file (versioned) > > Enabled function versioning for meson build for the library. > > Fixes: 30512af820fe ("meter: remove experimental flag from RFC4115 trTCM API") > Cc: stable@dpdk.org > > Signed-off-by: Ferruh Yigit > --- > Cc: Neil Horman > Cc: Thomas Monjalon > Cc: Luca Boccassi > Cc: David Marchand > Cc: Bruce Richardson > Cc: Ian Stokes > Cc: Eelco Chaudron > Cc: Andrzej Ostruszka > Cc: Ray Kinsella > > v2: > * Commit log updated > > v3: > * added suggested comment to VERSION_SYMBOL_EXPERIMENTAL macro > > v4: > * update script name in commit log, remove empty line > --- > buildtools/check-symbols.sh | 3 +- > .../include/rte_function_versioning.h | 9 +++ > lib/librte_meter/meson.build | 1 + > lib/librte_meter/rte_meter.c | 59 ++++++++++++++++++- > lib/librte_meter/rte_meter_version.map | 8 +++ > 5 files changed, 76 insertions(+), 4 deletions(-) This patch is introducing the tooling and use it for the lib meter. It is based on approval of the process documentation. Ray sent a patch for the process documentation which refers to this tooling. As raised by David, there is a circular dependency :) I think it would be clearer to merge tooling and doc together, and have meter changes separate. Would it work for you?