From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f179.google.com (mail-wi0-f179.google.com [209.85.212.179]) by dpdk.org (Postfix) with ESMTP id 945D0594F for ; Thu, 13 Nov 2014 01:40:24 +0100 (CET) Received: by mail-wi0-f179.google.com with SMTP id h11so6671140wiw.6 for ; Wed, 12 Nov 2014 16:50:20 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=k9v2j822RDdQBG1bbi07c8u7l810Y9oS5Jkhz8EJ8uw=; b=FvaiiQGtJUO/YUeVr2djfurCjQzj5nVAPmrp4r6oze0OTVQhKCSivN0qeuE3j/wyTH PMnGOuFokno9IREUSioNcoJqXiPOMrIe21s3nMOo4Ld3gMNuPNpVFLEgDM+UcvHgJaAW kuW3jGvJvghyrxL6OpsvzAGDbx0JD8vOTvJbZQuUb90gaBB8nFIULSAxDqLTvUKFI8hI 6N/C7BXRWfb8xg7I4AczwtZDzPfP2xvFXbijfnxnss42fkDN4vtHlnAx9atzl/adOpK8 4IgsTMcVC57eg0BZsJLrL0lyDrxr3D0pnDwSRnQCeVW/avaZnudU/vCrgckdUDeyhrgD oUWQ== X-Gm-Message-State: ALoCoQkiifgU3HdyTLb3Gn3bv1oM04f75czguwT6gLdtHepyXwVwie3bPwy8d/N9zQ3HgHzZPrwc X-Received: by 10.180.83.98 with SMTP id p2mr10771518wiy.20.1415839820646; Wed, 12 Nov 2014 16:50:20 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id n4sm23596539wiz.17.2014.11.12.16.50.19 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 12 Nov 2014 16:50:19 -0800 (PST) From: Thomas Monjalon To: Qinglai Xiao Date: Thu, 13 Nov 2014 01:50:01 +0100 Message-ID: <1795062.hHiWS5oXJV@xps13> Organization: 6WIND User-Agent: KMail/4.14.2 (Linux/3.17.2-1-ARCH; KDE/4.14.2; x86_64; ; ) In-Reply-To: <1415630642-3905-1-git-send-email-jigsaw@gmail.com> References: <1415630642-3905-1-git-send-email-jigsaw@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v3] Add in_flight_bitmask so as to use full 32 bits of tag. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Nov 2014 00:40:25 -0000 Hi, 2014-11-10 16:44, Qinglai Xiao: > With introduction of in_flight_bitmask, the whole 32 bits of tag can = be > used. Further more, this patch fixed the integer overflow when findin= g > the matched tags. > The maximum number workers is now defined as 64, which is length of > double-word. The link between number of workers and RTE_MAX_LCORE is > now removed. Compile time check is added to ensure the > RTE_DISTRIB_MAX_WORKERS is less than or equal to size of double-word.= >=20 > Signed-off-by: Qinglai Xiao The patch doesn't apply cleanly and fail to compile: lib/librte_distributor/rte_distributor.c:310:27: error: =E2=80=98union = =E2=80=99 has no member named =E2=80=98usr=E2=80=99 Do you have another commit before this one in your tree? --=20 Thomas