DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Tahhan, Maryam" <maryam.tahhan@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 4/4] app: replace dump_cfg with proc_info
Date: Mon, 08 Jun 2015 16:22:17 +0200	[thread overview]
Message-ID: <17952780.JlVN7MLQJO@xps13> (raw)
In-Reply-To: <1A27633A6DA49C4A92FCD5D4312DBF536A3E7834@IRSMSX109.ger.corp.intel.com>

2015-06-08 13:45, Tahhan, Maryam:
> > > Extend dump_cfg to also display statistcs information for given DPDK
> > > ports and rename the application to proc_info as it's now a utility
> > > doing a little more than just dumping the memory information for DPDK.
> > >
> > > Signed-off-by: Maryam Tahhan <maryam.tahhan@intel.com>
> > > ---
> > >  app/Makefile           |   2 +-
> > >  app/dump_cfg/Makefile  |  45 -----
> > >  app/dump_cfg/main.c    |  92 ---------
> > >  app/proc_info/Makefile |  45 +++++
> > >  app/proc_info/main.c   | 525
> > +++++++++++++++++++++++++++++++++++++++++++++++++
> > >  mk/rte.sdktest.mk      |   4 +-
> > 
> > It looks promising, thanks.
> > Would you consider adding yourself as a maintainer of this app?
> 
> Yep, I can do that. Should I add myself to the maintainers file in a separate patch, or as a reworked version of this patch?

In case there is no other comment, a separate patch is OK.
Thanks

      reply	other threads:[~2015-06-08 14:30 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-05 17:35 [dpdk-dev] [PATCH 0/4] expose ixgbe extended stats to dpdk apps Maryam Tahhan
2015-06-05 17:35 ` [dpdk-dev] [PATCH 1/4] ixgbe: expose extended error statistics Maryam Tahhan
2015-06-08 13:26   ` Tahhan, Maryam
2015-06-10  0:51   ` Stephen Hemminger
2015-06-10 14:24     ` Tahhan, Maryam
2015-06-17 12:52     ` Thomas Monjalon
2015-06-05 17:35 ` [dpdk-dev] [PATCH 2/4] ethdev: expose extended error stats Maryam Tahhan
2015-06-17 13:58   ` Thomas Monjalon
2015-06-17 14:47     ` Kyle Larose
2015-06-22 14:12     ` Tahhan, Maryam
2015-06-22 15:12       ` Olivier MATZ
2015-06-22 15:35         ` Tahhan, Maryam
2015-06-05 17:35 ` [dpdk-dev] [PATCH 3/4] testpmd: extend testpmd to show all extended stats Maryam Tahhan
2015-06-05 17:35 ` [dpdk-dev] [PATCH 4/4] app: replace dump_cfg with proc_info Maryam Tahhan
2015-06-05 21:08   ` Thomas Monjalon
2015-06-08 13:45     ` Tahhan, Maryam
2015-06-08 14:22       ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=17952780.JlVN7MLQJO@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=dev@dpdk.org \
    --cc=maryam.tahhan@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).