From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f181.google.com (mail-wi0-f181.google.com [209.85.212.181]) by dpdk.org (Postfix) with ESMTP id 3EDD568F0 for ; Wed, 2 Apr 2014 13:51:51 +0200 (CEST) Received: by mail-wi0-f181.google.com with SMTP id hm4so337179wib.2 for ; Wed, 02 Apr 2014 04:53:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=y77RVd7t367GwDLxNALl0luAeuouaoCqnEJEhBh6dpk=; b=FJsCHjx4wyLsL/Elhj3WHHi8lvU1fL96FaYPEJ/KxWfoFuVLFUHK8mc2pmqseAvzvV 7kSa5WbVUbN4MeTQSdqjv2PQHnuzXu8VWRWtrJp110cN2CLkOQ1zoj16gBUGGuQt+BWu +A8i1VUeKTJxZYXMHqPdOcuQx79+n6Nuc2coY+oVpWsxs+PApupxK0IwI0x8ouqxxh9C JyE6x2ze8sri2TLSYZGmG2oOXqXaZbbE12F5KJMyaEK69L+DW8KN8nt6E1OBl1lp/gJk BDu3BQx2dqa/Kud21qEk11YGmHlTyDXc/E0cEJnM8Gwt+MdabHX9yvoLbFndFSh+1HGY YD/g== X-Gm-Message-State: ALoCoQnsoEaln3qgSKtZNxGSceKygeMcl9wfBV+36eoOUOJYfZv2nk/ihuT0fH0z1fZQOoCUCS42 X-Received: by 10.180.101.40 with SMTP id fd8mr1407140wib.1.1396439606060; Wed, 02 Apr 2014 04:53:26 -0700 (PDT) Received: from xps13.localnet (6wind.net2.nerim.net. [213.41.180.237]) by mx.google.com with ESMTPSA id xs1sm2587970wjb.27.2014.04.02.04.53.24 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 02 Apr 2014 04:53:25 -0700 (PDT) From: Thomas Monjalon To: Neil Horman Date: Wed, 02 Apr 2014 13:53:24 +0200 Message-ID: <1795579.cUqpENC9aa@xps13> Organization: 6WIND User-Agent: KMail/4.12.3 (Linux/3.13.7-1-ARCH; KDE/4.12.3; x86_64; ; ) In-Reply-To: <20140402111643.GB6974@neilslaptop.think-freely.org> References: <20140320163921.GC7721@hmsreliant.think-freely.org> <5331EC38.2070901@linux.intel.com> <20140402111643.GB6974@neilslaptop.think-freely.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org, "H. Peter Anvin" Subject: Re: [dpdk-dev] [PATCH v5] eal_common_cpuflags: Fix %rbx corruption, and simplify the code X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Apr 2014 11:51:51 -0000 2014-04-02 07:16, Neil Horman: > On Tue, Mar 25, 2014 at 01:51:04PM -0700, H. Peter Anvin wrote: > > On 03/25/2014 12:52 PM, Neil Horman wrote: > > > Neil Horman reported that on x86-64 the upper half of %rbx would get > > > clobbered when the code was compiled PIC or PIE, because the > > > i386-specific code to preserve %ebx was incorrectly compiled. > > > > > > However, the code is really way more complex than it needs to be. For > > > one thing, the CPUID instruction only needs %eax (leaf) and %ecx > > > (subleaf) as parameters, and since we are testing for bits, we might > > > as well list the bits explicitly. Furthermore, we can use an array > > > rather than doing a switch statement inside a structure. > > > > > > Reported-by: Neil Horman > > > Signed-off-by: H. Peter Anvin > > > Signed-off-by: Neil Horman > > > > Looks good to me. > > > > Reviewed-by: H. Peter Anvin > > > > -hpa > > Bump, did this get lost somewhere? Its been over a week and I don't see it > in the tree No, it's not lost. But this patch is not trivial and there were 5 versions with acknowledgements in the middle. So I think it was not a bad idea to wait few days in order to be sure this version is OK :) -- Thomas